Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 19489003: Unify SMI case inlining for ToNumberStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4418 matching lines...) Expand 10 before | Expand all | Expand 10 after
4429 // We need a second deoptimization point after loading the value 4429 // We need a second deoptimization point after loading the value
4430 // in case evaluating the property load my have a side effect. 4430 // in case evaluating the property load my have a side effect.
4431 if (assign_type == VARIABLE) { 4431 if (assign_type == VARIABLE) {
4432 PrepareForBailout(expr->expression(), TOS_REG); 4432 PrepareForBailout(expr->expression(), TOS_REG);
4433 } else { 4433 } else {
4434 PrepareForBailoutForId(prop->LoadId(), TOS_REG); 4434 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
4435 } 4435 }
4436 4436
4437 // Call ToNumber only if operand is not a smi. 4437 // Call ToNumber only if operand is not a smi.
4438 Label no_conversion; 4438 Label no_conversion;
4439 __ JumpIfSmi(r0, &no_conversion); 4439 if (ShouldInlineSmiCase(expr->op())) {
4440 __ JumpIfSmi(r0, &no_conversion);
4441 }
4440 ToNumberStub convert_stub; 4442 ToNumberStub convert_stub;
4441 __ CallStub(&convert_stub); 4443 __ CallStub(&convert_stub);
4442 __ bind(&no_conversion); 4444 __ bind(&no_conversion);
4443 4445
4444 // Save result for postfix expressions. 4446 // Save result for postfix expressions.
4445 if (expr->is_postfix()) { 4447 if (expr->is_postfix()) {
4446 if (!context()->IsEffect()) { 4448 if (!context()->IsEffect()) {
4447 // Save the result on the stack. If we have a named or keyed property 4449 // Save the result on the stack. If we have a named or keyed property
4448 // we store the result under the receiver that is currently on top 4450 // we store the result under the receiver that is currently on top
4449 // of the stack. 4451 // of the stack.
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
4913 *context_length = 0; 4915 *context_length = 0;
4914 return previous_; 4916 return previous_;
4915 } 4917 }
4916 4918
4917 4919
4918 #undef __ 4920 #undef __
4919 4921
4920 } } // namespace v8::internal 4922 } } // namespace v8::internal
4921 4923
4922 #endif // V8_TARGET_ARCH_ARM 4924 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698