Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1948893002: Make sure the heap is in consistent state when calling allocation observers. (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure the heap is in consistent state when calling allocation observers. The observer might want to lookup something in the heap, e.g. code objects it has in the call stack. BUG=v8:4959 LOG=N Committed: https://crrev.com/e8e9c07e548ea5386f918e8a7f4f42d517725223 Cr-Commit-Position: refs/heads/master@{#36027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/spaces.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948893002/1
4 years, 7 months ago (2016-05-03 23:10:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 23:33:59 UTC) #4
alph
4 years, 7 months ago (2016-05-03 23:35:24 UTC) #6
ofrobots
On 2016/05/03 23:35:24, alph wrote: lgtm.
4 years, 7 months ago (2016-05-04 08:15:11 UTC) #7
ulan
lgtm
4 years, 7 months ago (2016-05-04 08:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948893002/1
4 years, 7 months ago (2016-05-04 14:36:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 14:38:18 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 14:40:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8e9c07e548ea5386f918e8a7f4f42d517725223
Cr-Commit-Position: refs/heads/master@{#36027}

Powered by Google App Engine
This is Rietveld 408576698