Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1948873002:
[sanitizers] do not add -lclang_rt on mac. (Closed)
Description[sanitizers] do not add -lclang_rt on mac.
Clang frontend adds appropriate -l options automatically depending
on -fsanitize value.
BUG=597066
Committed: https://crrev.com/8af17fa910a2e11ca06419d302a302a963399929
Cr-Commit-Position: refs/heads/master@{#391578}
Patch Set 1 #Patch Set 2 : sync #
Messages
Total messages: 23 (12 generated)
Description was changed from ========== [sanitizers] do not add -lclang_rt on mac. Clang frontend adds appropriate -l options automatically depending on -fsanitize value. BUG=597066 ========== to ========== [sanitizers] do not add -lclang_rt on mac. Clang frontend adds appropriate -l options automatically depending on -fsanitize value. BUG=597066 ==========
aizatsky@chromium.org changed reviewers: + eugenis@chromium.org, rsesek@chromium.org
eugenis@google.com changed reviewers: + eugenis@google.com
lgtm
lgtm
The CQ bit was checked by aizatsky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948873002/1
aizatsky@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by aizatsky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948873002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by aizatsky@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org, brettw@chromium.org, eugenis@google.com Link to the patchset: https://codereview.chromium.org/1948873002/#ps20001 (title: "sync")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948873002/20001
Message was sent while issue was closed.
Description was changed from ========== [sanitizers] do not add -lclang_rt on mac. Clang frontend adds appropriate -l options automatically depending on -fsanitize value. BUG=597066 ========== to ========== [sanitizers] do not add -lclang_rt on mac. Clang frontend adds appropriate -l options automatically depending on -fsanitize value. BUG=597066 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [sanitizers] do not add -lclang_rt on mac. Clang frontend adds appropriate -l options automatically depending on -fsanitize value. BUG=597066 ========== to ========== [sanitizers] do not add -lclang_rt on mac. Clang frontend adds appropriate -l options automatically depending on -fsanitize value. BUG=597066 Committed: https://crrev.com/8af17fa910a2e11ca06419d302a302a963399929 Cr-Commit-Position: refs/heads/master@{#391578} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8af17fa910a2e11ca06419d302a302a963399929 Cr-Commit-Position: refs/heads/master@{#391578} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
