Reland: Add ability to override DEPS file in recursedeps

Reland: Add ability to override DEPS file in recursedeps

This will allow ANGLE to have a recursible deps-file in their repo instead of
relying on chromium's DEPS file to specify an accurate dependency for itself.

Previously: https://chromiumcodereview.appspot.com/1919103003/

R=agable@chromium.org, dpranke@chromium.org, jmadill@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300446

[iannucci, 2016-05-03 22:39:29]

https://chromiumcodereview.appspot.com/1948853002/diff/20001/gclient.py
File gclient.py (left):

https://chromiumcodereview.appspot.com/1948853002/diff/20001/gclient.py#oldco...
gclient.py:713: self.deps_file, should_process))
The existing behavior ALWAYS assumed self.deps_file. In patchset 2 we now use
that as the default value when recursedeps is specified. Patchset 1 worked for
non-infra repos because only the infra repos use recursedeps right now AND use
non-default DEPS files.

[iannucci, 2016-05-03 22:39:44]

On 2016/05/03 22:39:29, iannucci wrote:
> https://chromiumcodereview.appspot.com/1948853002/diff/20001/gclient.py
> File gclient.py (left):
> 
>
https://chromiumcodereview.appspot.com/1948853002/diff/20001/gclient.py#oldco...
> gclient.py:713: self.deps_file, should_process))
> The existing behavior ALWAYS assumed self.deps_file. In patchset 2 we now use
> that as the default value when recursedeps is specified. Patchset 1 worked for
> non-infra repos because only the infra repos use recursedeps right now AND use
> non-default DEPS files.

Oops, missed the PTAL :)

[Jamie Madill, 2016-05-03 23:47:54]

LGTM from ANGLE's point of view, though I'm not any use for the CL logic

[iannucci, 2016-05-04 05:30:12]

On 2016/05/03 23:47:54, Jamie Madill wrote:
> LGTM from ANGLE's point of view, though I'm not any use for the CL logic

I'll submit this tomorrow morning.

[iannucci, 2016-05-04 22:14:58]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-05-04 22:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948853002/20001

[commit-bot: I haz the power, 2016-05-04 22:17:35]

Description was changed from

==========
Reland: Add ability to override DEPS file in recursedeps

This will allow ANGLE to have a recursible deps-file in their repo instead of
relying on chromium's DEPS file to specify an accurate dependency for itself.

Previously: https://chromiumcodereview.appspot.com/1919103003/

R=agable@chromium.org, dpranke@chromium.org, jmadill@chromium.org
BUG=
==========

to

==========
Reland: Add ability to override DEPS file in recursedeps

This will allow ANGLE to have a recursible deps-file in their repo instead of
relying on chromium's DEPS file to specify an accurate dependency for itself.

Previously: https://chromiumcodereview.appspot.com/1919103003/

R=agable@chromium.org, dpranke@chromium.org, jmadill@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300446
==========

[commit-bot: I haz the power, 2016-05-04 22:17:35]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300446

[Dirk Pranke, 2016-05-04 22:49:59]

lgtm w/ comment.

https://codereview.chromium.org/1948853002/diff/20001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/1948853002/diff/20001/gclient.py#newcode663
gclient.py:663: self.recursedeps[ent[0]] = {"deps_file": ent[1]}
the document above only says that dicts are supported. Are we supporting strings
for backwards compatibility? If so, we should either note that in the doc, or
file a TODO bug to make sure to update any callers, or do both.

[iannucci, 2016-05-05 04:08:05]

Ah, the internal representation is a dict now (which is what that comment
is about), but the incoming format (both old and new) are undocumented :(

I'll see if there's a place to document this.

On Wed, May 4, 2016, 15:50 <dpranke@chromium.org> wrote:

> lgtm w/ comment.
>
>
> https://codereview.chromium.org/1948853002/diff/20001/gclient.py
> File gclient.py (right):
>
> https://codereview.chromium.org/1948853002/diff/20001/gclient.py#newcode663
> gclient.py:663: self.recursedeps[ent[0]] = {"deps_file": ent[1]}
> the document above only says that dicts are supported. Are we supporting
> strings for backwards compatibility? If so, we should either note that
> in the doc, or file a TODO bug to make sure to update any callers, or do
> both.
>
> https://codereview.chromium.org/1948853002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.