Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: test/ninja/normalize-paths-win/gyptest-normalize-paths.py

Issue 194883010: Fix missing variable MSVS expansion of copies arguments with Ninja. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: remove print Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ninja/normalize-paths-win/normalize-paths.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ninja/normalize-paths-win/gyptest-normalize-paths.py
diff --git a/test/ninja/normalize-paths-win/gyptest-normalize-paths.py b/test/ninja/normalize-paths-win/gyptest-normalize-paths.py
index af48d071cf90594beea585c29e11c09a5b1b06ef..f56dbe5921e2e896c55d363e323c59d7f6180159 100644
--- a/test/ninja/normalize-paths-win/gyptest-normalize-paths.py
+++ b/test/ninja/normalize-paths-win/gyptest-normalize-paths.py
@@ -31,6 +31,10 @@ if sys.platform == 'win32':
'AnotherName.exe' not in second):
test.fail_test()
+ copytarget = open(test.built_file_path('obj/copy_target.ninja')).read()
+ if '$(VSInstallDir)' in copytarget:
+ test.fail_test()
+
action = open(test.built_file_path('obj/action.ninja')).read()
if '..\\..\\out\\Default' in action:
test.fail_test()
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ninja/normalize-paths-win/normalize-paths.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698