Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 194883004: Drop executable flag from headers so that they can be packaged (Closed)

Created:
6 years, 9 months ago by Dmitry.Rojkov
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Drop executable flag from headers so that they can be packaged into rpm's without lintian errors.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-19 lines, --19 lines) Patch
M include/core/SkAdvancedTypefaceMetrics.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/utils/ios/SkStream_NSData.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/views/SkOSWindow_iOS.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/core/SkTRefArray.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrAllocator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pdf/SkPDFFontImpl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/utils/SkBitSet.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/edtaa/edtaa3.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/fontconfig/config/fc-case/fccase.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/fontconfig/config/fc-glyphname/fcglyphname.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/fontconfig/config/fc-lang/fclang.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/poppler/config/windows/config.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/poppler/config/windows/poppler-config.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
lgtm
6 years, 9 months ago (2014-03-11 19:25:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/Dmitry.Rojkov@gmail.com/194883004/1
6 years, 9 months ago (2014-03-11 19:25:45 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 19:25:50 UTC) #3
commit-bot: I haz the power
Can't process patch for file src/gpu/effects/GrDistanceFieldTextureEffect.h. Change with status ' M ' is not supported.
6 years, 9 months ago (2014-03-11 19:25:51 UTC) #4
reed1
6 years, 9 months ago (2014-03-11 19:40:52 UTC) #5
reed1
author: how did you come up with this list? Our commit-queue doesn't seem to understand ...
6 years, 9 months ago (2014-03-11 19:43:40 UTC) #6
Dmitry.Rojkov
On 2014/03/11 19:43:40, reed1 wrote: > author: how did you come up with this list? ...
6 years, 9 months ago (2014-03-11 19:48:36 UTC) #7
robertphillips
6 years, 9 months ago (2014-03-11 19:56:16 UTC) #8
Message was sent while issue was closed.
committed as r13746.

Powered by Google App Engine
This is Rietveld 408576698