Issue 194883003: Make sure tagged binary op instructions change new space promotion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194883003: Make sure tagged binary op instructions change new space promotion. (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Make sure tagged binary op instructions change new space promotion. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19790

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -6 lines)			Patch
	M	src/hydrogen-instructions.h	View		6 chunks	+6 lines, -6 lines	0 comments	Download
	M	test/cctest/test-heap.cc	View		1 chunk	+42 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM, thanks for fixing this! For the record, it would be kinda nice to have ...

6 years, 9 months ago (2014-03-11 10:50:10 UTC) #2

Hannes Payer (out of office)

6 years, 9 months ago (2014-03-11 11:37:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19790 (presubmit successful).