Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1948803002: Adds DBC StoreIntoObject test (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M runtime/vm/assembler_dbc_test.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/vm/assembler_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/unit_test.h View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 7 months ago (2016-05-03 21:32:17 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/1948803002/diff/1/runtime/vm/unit_test.h File runtime/vm/unit_test.h (right): https://codereview.chromium.org/1948803002/diff/1/runtime/vm/unit_test.h#newcode445 runtime/vm/unit_test.h:445: const Array& arguments = Array::Handle(Array::New(2)); This is unsafe. ...
4 years, 7 months ago (2016-05-03 21:39:02 UTC) #3
zra
https://codereview.chromium.org/1948803002/diff/1/runtime/vm/unit_test.h File runtime/vm/unit_test.h (right): https://codereview.chromium.org/1948803002/diff/1/runtime/vm/unit_test.h#newcode445 runtime/vm/unit_test.h:445: const Array& arguments = Array::Handle(Array::New(2)); On 2016/05/03 21:39:02, Vyacheslav ...
4 years, 7 months ago (2016-05-03 21:58:33 UTC) #4
zra
4 years, 7 months ago (2016-05-03 21:58:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fc65d07fdfd054dd3b6d8419d7b3910aeecaf0d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698