Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 19488002: Introduce toHTMLSelectElement and remove isHTMLSelectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1969 matching lines...) Expand 10 before | Expand all | Expand 10 after
1980 if (!document) { 1980 if (!document) {
1981 ec = InvalidAccessError; 1981 ec = InvalidAccessError;
1982 return String(); 1982 return String();
1983 } 1983 }
1984 1984
1985 return document->baseURL().string(); 1985 return document->baseURL().string();
1986 } 1986 }
1987 1987
1988 bool Internals::isSelectPopupVisible(Node* node) 1988 bool Internals::isSelectPopupVisible(Node* node)
1989 { 1989 {
1990 if (!isHTMLSelectElement(node)) 1990 if (!node->hasTagName(HTMLNames::selectTag))
tkent 2013/07/17 01:47:56 This isHTMLSelectElement usage is good because toH
kangil_ 2013/07/17 02:16:22 I understood that we agree to remove isFooElement
1991 return false; 1991 return false;
1992 1992
1993 HTMLSelectElement* select = toHTMLSelectElement(node); 1993 HTMLSelectElement* select = toHTMLSelectElement(node);
1994 1994
1995 RenderObject* renderer = select->renderer(); 1995 RenderObject* renderer = select->renderer();
1996 if (!renderer->isMenuList()) 1996 if (!renderer->isMenuList())
1997 return false; 1997 return false;
1998 1998
1999 RenderMenuList* menuList = toRenderMenuList(renderer); 1999 RenderMenuList* menuList = toRenderMenuList(renderer);
2000 return menuList->popupIsVisible(); 2000 return menuList->popupIsVisible();
2001 } 2001 }
2002 2002
2003 } 2003 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698