device/bluetooth/test/mock_bluetooth_cbservice_mac.h - Issue 1948763003: Adding support for service scan on OS X

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/bluetooth/test/mock_bluetooth_cbservice_mac.h

Issue 1948763003: Adding support for service scan on OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup

Patch Set: Adding disconnect with error Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm ('K') | « device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm ('k') | device/bluetooth/test/mock_bluetooth_cbservice_mac.mm » ('j') | device/bluetooth/test/mock_bluetooth_cbservice_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	ortuno 2016/05/06 16:03:34 nit: 2016 :) nit: 2016 :) jlebel 2016/05/07 00:16:12 Done. Show quoted text On 2016/05/06 16:03:34, ortuno wrote: > nit: 2016 :) Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBSERVICE_MAC_H_
	ortuno 2016/05/06 16:03:34 I think the correct ifndef should be: DEVICE_BLUE I think the correct ifndef should be: DEVICE_BLUETOOTH_TEST_MOCK_BLUETOOTH_CBSERVICE_MAC_H_ jlebel 2016/05/07 00:16:12 Done. Show quoted text On 2016/05/06 16:03:34, ortuno wrote: > I think the correct ifndef should be: > > DEVICE_BLUETOOTH_TEST_MOCK_BLUETOOTH_CBSERVICE_MAC_H_ Done.
	6 #define DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBSERVICE_MAC_H_

	7

	8 #include "base/mac/sdk_forward_declarations.h"

	9 #include "build/build_config.h"

	10

	11 #import <CoreBluetooth/CoreBluetooth.h>

	12

	13 // This class mocks the behavior of a CBService.

	14 @interface MockCBService : NSObject

	15

	16 @property(readonly, nonatomic) CBUUID* UUID;
	ortuno 2016/05/06 16:03:34 Shouldn't the service own the UUID rather than kee Shouldn't the service own the UUID rather than keeping a pointer to it? jlebel 2016/05/07 00:16:12 Done. Show quoted text On 2016/05/06 16:03:34, ortuno wrote: > Shouldn't the service own the UUID rather than keeping a pointer to it? Done.
	17 @property(readonly, nonatomic) BOOL isPrimary;

	18 @property(readonly, nonatomic) CBService* service;

	19

	20 - (instancetype)initWithCBUUID:(CBUUID*)uuid primary:(BOOL)isPrimary;
	ortuno 2016/05/06 16:03:34 nit: isPrimary:(BOOL)isPrimary nit: isPrimary:(BOOL)isPrimary jlebel 2016/05/07 00:16:12 That's not the usual way to name methods in Obj-C: Show quoted text On 2016/05/06 16:03:34, ortuno wrote: > nit: isPrimary:(BOOL)isPrimary That's not the usual way to name methods in Obj-C: CBMutableService: - (id)initWithType:(nullable CBUUID )UUID primary:(BOOL)isPrimary; ortuno* 2016/05/09 19:54:01 Ah ok. Show quoted text On 2016/05/07 at 00:16:12, jlebel wrote: > On 2016/05/06 16:03:34, ortuno wrote: > > nit: isPrimary:(BOOL)isPrimary > > That's not the usual way to name methods in Obj-C: > > CBMutableService: > - (id)initWithType:(nullable CBUUID *)UUID primary:(BOOL)isPrimary; Ah ok.
	21

	22 @end

	23

	24 #endif // DEVICE_BLUETOOTH_MOCK_BLUETOOTH_CBSERVICE_MAC_H_

OLD	NEW