Adding support for service scan on OS X

device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm

+// Copyright 2015 The Chromium Authors. All rights reserved.

[ortuno, 2016/05/06 16:03:33]

nit: 2016

[jlebel, 2016/05/07 00:16:11]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "device/bluetooth/bluetooth_low_energy_peripheral_delegate.h"
+
+#include "device/bluetooth/bluetooth_adapter_mac.h"
+#include "device/bluetooth/bluetooth_low_energy_discovery_manager_mac.h"
+
+namespace device {
+
+// This class exists to bridge between the Objective-C CBPeripheralDelegate
+// class and our BluetoothLowEnergyDiscoveryManagerMac and BluetoothAdapterMac
+// classes.

[ortuno, 2016/05/06 16:03:33]

Out of curiosity: why do we need this class? Why can't
BluetoothLowEnergyDeviceMac implement CBPeripheralDelegate's methods? Also why
can't the BluetoothLowEnergyPeripheralDelegate call directly into
BluetoothLowEnergyDeviceMac?

[jlebel, 2016/05/07 00:16:11]

I'm following the pattern that already exist for
BluetoothLowEnergyCentralManagerDelegate. I'm guessing the benefit of this
complex pattern is to have protected methods in BluetoothLowEnergyDeviceMac that
can be called by the friend BluetoothLowEnergyPeripheralBridge.

If you don't mind moving the methods from private to public, I can remove this
class. And I will do the same in the other class (in another patch).

[ortuno, 2016/05/09 19:54:00]

It's OK. I just wanted to know the background for this pattern.

+class BluetoothLowEnergyPeripheralBridge {
+ public:
+  BluetoothLowEnergyPeripheralBridge(BluetoothLowEnergyDeviceMac* device_mac)
+      : device_mac_(device_mac) {}
+
+  virtual ~BluetoothLowEnergyPeripheralBridge() {}

[ortuno, 2016/05/06 16:03:33]

Why do you need the virtual here?

[jlebel, 2016/05/07 00:16:11]

Done.

+
+  void DidModifyServices(NSArray* invalidatedServices) {
+    device_mac_->DidModifyServices(invalidatedServices);
+  }
+
+  void DidDiscoverPrimaryServices(NSError* error) {
+    device_mac_->DidDiscoverPrimaryServices(error);
+  };
+
+  CBPeripheral* GetPeripheral() { return device_mac_->GetPeripheral(); }
+
+ private:
+  BluetoothLowEnergyDeviceMac* device_mac_;
+};
+
+}  // namespace device
+
+@implementation BluetoothLowEnergyPeripheralDelegate
+
+- (id)initWithBluetoothLowEnergyDeviceMac:
+    (device::BluetoothLowEnergyDeviceMac*)device_mac {
+  if ((self = [super init])) {
+    bridge_.reset(new device::BluetoothLowEnergyPeripheralBridge(device_mac));
+  }
+  return self;
+}
+
+- (void)dealloc {
+  [bridge_->GetPeripheral() setDelegate:nil];
+  [super dealloc];
+}
+
+- (void)peripheral:(CBPeripheral*)peripheral
+    didModifyServices:(NSArray*)invalidatedServices {
+  bridge_->DidModifyServices(invalidatedServices);
+}
+
+- (void)peripheral:(CBPeripheral*)peripheral
+    didDiscoverServices:(NSError*)error {
+  bridge_->DidDiscoverPrimaryServices(error);
+}
+
+@end