Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1948763002: [EventSender] Fill DomKey in synthetic key events (Closed)

Created:
4 years, 7 months ago by chongz
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, dtapuska, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[EventSender] Fill DomKey in synthetic key events With the ship of DomKey and the proposed removal of keyIdentifier we need to be able to updated the layout tests and start using DomKey. BUG=608351 Committed: https://crrev.com/40aff9364e9e84bc98ac26eda1024df88512863e Cr-Commit-Position: refs/heads/master@{#391503}

Patch Set 1 : Fill DomKey in EventSender, update tests #

Patch Set 2 : Remove two more keyboardevent-key-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -271 lines) Patch
M components/test_runner/event_sender.cc View 5 chunks +63 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/keyboardevent-key.html View 1 chunk +72 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/keyboardevent-key-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/keyboardevent-key-expected.txt View 1 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/trustedeventsdefaultaction/fast/events/keyboardevent-key-expected.txt View 1 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chongz
jochen@, can you take a look at this CL please? This CL fills DomKey field ...
4 years, 7 months ago (2016-05-04 02:58:52 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-04 10:58:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948763002/20001
4 years, 7 months ago (2016-05-04 14:26:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 14:30:21 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 14:31:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40aff9364e9e84bc98ac26eda1024df88512863e
Cr-Commit-Position: refs/heads/master@{#391503}

Powered by Google App Engine
This is Rietveld 408576698