Issue 194873003: ArrayUnshift() should not modify length of a frozen object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194873003: ArrayUnshift() should not modify length of a frozen object. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko

Modified:
6 years, 9 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ArrayUnshift() should not modify length of a frozen object. BUG=350890 LOG=N

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/array.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-350890.js	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

6 years, 9 months ago (2014-03-17 15:41:28 UTC) #3

On 2014/03/11 13:19:49, mvstanton wrote:
> lgtm

It happened that this fix did not fix the real problem, which is actually fixed
in https://codereview.chromium.org/196653015/

Expand Messages | Collapse Messages