Chromium Code Reviews

Unified Diff: sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_maps_in_debug_test.dart

Issue 194863003: Don't include source maps in release mode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Don't include source maps at all in release builds. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_maps_in_debug_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart b/sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_maps_in_debug_test.dart
similarity index 68%
rename from sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart
rename to sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_maps_in_debug_test.dart
index ee5587a21376abe18c856ba39d121f8588193d2f..c59a9ccd648fbaa236ac851b0aaf006a55ccd894 100644
--- a/sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart
+++ b/sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_maps_in_debug_test.dart
@@ -11,7 +11,7 @@ import '../../test_pub.dart';
main() {
initConfig();
- integration("includes proper URLs in generated JS and source map", () {
+ integration("includes source map URLs in a debug build", () {
d.dir(appPath, [
d.appPubspec(),
d.dir("web", [
@@ -19,17 +19,15 @@ main() {
])
]).create();
- schedulePub(args: ["build"],
- output: new RegExp(r'Built 3 files to "build".'),
+ schedulePub(args: ["build", "--mode", "debug"],
+ output: new RegExp(r'Built 4 files to "build".'),
exitCode: 0);
d.dir(appPath, [
d.dir('build', [
d.dir('web', [
- d.matcherFile('main.dart.js', allOf([
- contains("# sourceMappingURL=main.dart.js.map"),
- contains("@ sourceMappingURL=main.dart.js.map")
- ])),
+ d.matcherFile('main.dart.js',
+ contains("# sourceMappingURL=main.dart.js.map")),
d.matcherFile('main.dart.js.map', contains('"file": "main.dart.js"'))
])
])

Powered by Google App Engine