Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: test/mjsunit/compiler/division-by-constant.js

Issue 194863002: Disable special handling of flooring division by constant until it is fixed for real. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified test. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // Flags: --allow-natives-syntax --no-use-inlining
29
30 // -----------------------------------------------------------------------------
31
32 function ConstructDiv(divisor) {
33 return "return ((dividend | 0) / ((" + divisor + ") | 0)) | 0";
34 }
35
36 var RefDivByConstI =
37 new Function("dividend", "divisor", ConstructDiv("divisor"));
38
39 %NeverOptimizeFunction(RefDivByConstI);
40
41 // -----------------------------------------------------------------------------
42
43 function ConstructMod(divisor) {
44 return "return ((dividend | 0) % ((" + divisor + ") | 0)) | 0";
45 }
46
47 var RefModByConstI =
48 new Function("dividend", "divisor", ConstructMod("divisor"));
49
50 %NeverOptimizeFunction(RefModByConstI);
51
52 // -----------------------------------------------------------------------------
53
54 function ConstructFlooringDiv(divisor) {
55 return "return Math.floor(dividend / (" + divisor + ")) | 0";
56 }
57
58 var RefFlooringDivByConstI =
59 new Function("dividend", "divisor", ConstructFlooringDiv("divisor"));
60
61 %NeverOptimizeFunction(RefFlooringDivByConstI);
62
63 // -----------------------------------------------------------------------------
64
65 function PushSymmetric(values, x) {
66 values.push(x, -x);
67 }
68
69 function PushRangeSymmetric(values, from, to) {
70 for (var x = from; x <= to; x++) {
71 PushSymmetric(values, x);
72 }
73 }
74
75 function CreateTestValues() {
76 var values = [
77 // -(2^31)
78 -2147483648,
79 // Some values from "Hacker's Delight", chapter 10-7.
80 715827883, 1431655766, -1431655765, -1431655764,
81 // Some "randomly" chosen numbers.
82 123, -1234, 12345, -123456, 1234567, -12345678, 123456789
83 ];
84 // Powers of 2
85 for (var shift = 6; shift < 31; shift++) {
86 PushSymmetric(values, 1 << shift);
87 }
88 // Values near zero
89 PushRangeSymmetric(values, 1, 32);
90 // Various magnitudes
91 PushRangeSymmetric(values, 100, 109);
92 PushRangeSymmetric(values, 1000, 1009);
93 PushRangeSymmetric(values, 10000, 10009);
94 PushRangeSymmetric(values, 100000, 100009);
95 PushRangeSymmetric(values, 1000000, 1000009);
96 PushRangeSymmetric(values, 10000000, 10000009);
97 PushRangeSymmetric(values, 100000000, 100000009);
98 PushRangeSymmetric(values, 1000000000, 1000000009);
99 return values;
100 }
101
102 // -----------------------------------------------------------------------------
103
104 function TestDivisionLike(ref, construct, values, divisor) {
105 // Define the function to test.
106 var OptFun = new Function("dividend", construct(divisor));
107
108 // Warm up type feedback.
109 OptFun(7);
110 OptFun(11);
111 %OptimizeFunctionOnNextCall(OptFun);
112 OptFun(13);
113
114 // Check results.
115 values.forEach(function(dividend) {
116 // Avoid deopt caused by overflow, we do not want to test this here.
117 if (dividend === -2147483648 && divisor === -1) return;
118 assertEquals(ref(dividend, divisor), OptFun(dividend));
119 });
120 }
121
122 function Test(ref, construct) {
123 var values = CreateTestValues();
124 values.forEach(function(divisor) {
125 TestDivisionLike(ref, construct, values, divisor);
126 });
127 }
128
129 Test(RefDivByConstI, ConstructDiv);
130 Test(RefModByConstI, ConstructMod);
131 Test(RefFlooringDivByConstI, ConstructFlooringDiv);
OLDNEW
« no previous file with comments | « src/x64/lithium-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698