Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 194863002: Disable special handling of flooring division by constant until it is fixed for real. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified test. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | test/mjsunit/compiler/division-by-constant.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1356 bool can_deopt = 1356 bool can_deopt =
1357 divisor == 0 || 1357 divisor == 0 ||
1358 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0); 1358 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0);
1359 return can_deopt ? AssignEnvironment(result) : result; 1359 return can_deopt ? AssignEnvironment(result) : result;
1360 } 1360 }
1361 1361
1362 1362
1363 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) { 1363 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) {
1364 if (instr->RightIsPowerOf2()) { 1364 if (instr->RightIsPowerOf2()) {
1365 return DoFlooringDivByPowerOf2I(instr); 1365 return DoFlooringDivByPowerOf2I(instr);
1366 } else if (instr->right()->IsConstant()) { 1366 } else if (false && instr->right()->IsConstant()) {
1367 return DoFlooringDivByConstI(instr); 1367 return DoFlooringDivByConstI(instr); // TODO(svenpanne) Fix and re-enable.
1368 } else { 1368 } else {
1369 return DoDivI(instr); 1369 return DoDivI(instr);
1370 } 1370 }
1371 } 1371 }
1372 1372
1373 1373
1374 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) { 1374 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) {
1375 ASSERT(instr->representation().IsSmiOrInteger32()); 1375 ASSERT(instr->representation().IsSmiOrInteger32());
1376 ASSERT(instr->left()->representation().Equals(instr->representation())); 1376 ASSERT(instr->left()->representation().Equals(instr->representation()));
1377 ASSERT(instr->right()->representation().Equals(instr->representation())); 1377 ASSERT(instr->right()->representation().Equals(instr->representation()));
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
2527 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2527 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2528 LOperand* object = UseRegister(instr->object()); 2528 LOperand* object = UseRegister(instr->object());
2529 LOperand* index = UseTempRegister(instr->index()); 2529 LOperand* index = UseTempRegister(instr->index());
2530 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2530 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2531 } 2531 }
2532 2532
2533 2533
2534 } } // namespace v8::internal 2534 } } // namespace v8::internal
2535 2535
2536 #endif // V8_TARGET_ARCH_X64 2536 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | test/mjsunit/compiler/division-by-constant.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698