Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 194863002: Disable special handling of flooring division by constant until it is fixed for real. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified test. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1424 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 bool can_deopt = 1435 bool can_deopt =
1436 divisor == 0 || 1436 divisor == 0 ||
1437 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0); 1437 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0);
1438 return can_deopt ? AssignEnvironment(result) : result; 1438 return can_deopt ? AssignEnvironment(result) : result;
1439 } 1439 }
1440 1440
1441 1441
1442 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) { 1442 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) {
1443 if (instr->RightIsPowerOf2()) { 1443 if (instr->RightIsPowerOf2()) {
1444 return DoFlooringDivByPowerOf2I(instr); 1444 return DoFlooringDivByPowerOf2I(instr);
1445 } else if (instr->right()->IsConstant()) { 1445 } else if (false && instr->right()->IsConstant()) {
1446 return DoFlooringDivByConstI(instr); 1446 return DoFlooringDivByConstI(instr); // TODO(svenpanne) Fix and re-enable.
1447 } else { 1447 } else {
1448 return DoDivI(instr); 1448 return DoDivI(instr);
1449 } 1449 }
1450 } 1450 }
1451 1451
1452 1452
1453 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) { 1453 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) {
1454 ASSERT(instr->representation().IsSmiOrInteger32()); 1454 ASSERT(instr->representation().IsSmiOrInteger32());
1455 ASSERT(instr->left()->representation().Equals(instr->representation())); 1455 ASSERT(instr->left()->representation().Equals(instr->representation()));
1456 ASSERT(instr->right()->representation().Equals(instr->representation())); 1456 ASSERT(instr->right()->representation().Equals(instr->representation()));
(...skipping 1219 matching lines...) Expand 10 before | Expand all | Expand 10 after
2676 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2676 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2677 LOperand* object = UseRegister(instr->object()); 2677 LOperand* object = UseRegister(instr->object());
2678 LOperand* index = UseTempRegister(instr->index()); 2678 LOperand* index = UseTempRegister(instr->index());
2679 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2679 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2680 } 2680 }
2681 2681
2682 2682
2683 } } // namespace v8::internal 2683 } } // namespace v8::internal
2684 2684
2685 #endif // V8_TARGET_ARCH_IA32 2685 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698