Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 194863002: Disable special handling of flooring division by constant until it is fixed for real. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified test. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/lithium-a64.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1337 bool can_deopt = 1337 bool can_deopt =
1338 divisor == 0 || 1338 divisor == 0 ||
1339 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0); 1339 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0);
1340 return can_deopt ? AssignEnvironment(result) : result; 1340 return can_deopt ? AssignEnvironment(result) : result;
1341 } 1341 }
1342 1342
1343 1343
1344 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) { 1344 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) {
1345 if (instr->RightIsPowerOf2()) { 1345 if (instr->RightIsPowerOf2()) {
1346 return DoFlooringDivByPowerOf2I(instr); 1346 return DoFlooringDivByPowerOf2I(instr);
1347 } else if (instr->right()->IsConstant()) { 1347 } else if (false && instr->right()->IsConstant()) {
1348 return DoFlooringDivByConstI(instr); 1348 return DoFlooringDivByConstI(instr); // TODO(svenpanne) Fix and re-enable.
1349 } else { 1349 } else {
1350 return DoDivI(instr); 1350 return DoDivI(instr);
1351 } 1351 }
1352 } 1352 }
1353 1353
1354 1354
1355 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) { 1355 LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) {
1356 ASSERT(instr->representation().IsSmiOrInteger32()); 1356 ASSERT(instr->representation().IsSmiOrInteger32());
1357 ASSERT(instr->left()->representation().Equals(instr->representation())); 1357 ASSERT(instr->left()->representation().Equals(instr->representation()));
1358 ASSERT(instr->right()->representation().Equals(instr->representation())); 1358 ASSERT(instr->right()->representation().Equals(instr->representation()));
(...skipping 1173 matching lines...) Expand 10 before | Expand all | Expand 10 after
2532 } 2532 }
2533 2533
2534 2534
2535 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2535 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2536 LOperand* object = UseRegister(instr->object()); 2536 LOperand* object = UseRegister(instr->object());
2537 LOperand* index = UseRegister(instr->index()); 2537 LOperand* index = UseRegister(instr->index());
2538 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2538 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2539 } 2539 }
2540 2540
2541 } } // namespace v8::internal 2541 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/a64/lithium-a64.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698