Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1948573003:
[heap] Add regression test for chromium:598319 (Closed)
|
Created:
4 years, 7 months ago by Michael Lippautz Modified:
4 years, 7 months ago Reviewers:
Hannes Payer (out of office) CC:
Hannes Payer (out of office), Camillo Bruni, Jakob Kummerow, ulan, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Add regression test for chromium:598319
BUG=chromium:598319
LOG=N
Committed: https://crrev.com/07c72af0d7c66ec0e7baad3e72b6b74a8feb7477
Cr-Commit-Position: refs/heads/master@{#36011}
Patch Set 1 : #Patch Set 2 : Make test independent of platform bitness #Patch Set 3 : Finish sweeping before checking invariants #
Messages
Total messages: 22 (12 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [heap] Add regression test for crbug.com/598319 BUG=chromium:598319 LOG=N ========== to ========== [heap] Add regression test for chromium:598319 BUG=chromium:598319 LOG=N ==========
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
hpayer: ptal cbruni/jkummerow: fyi. The fix already landed yesterday. I am not surprised that you had a hard time trying to get a JS repro ;)
lgtm
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948573003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948573003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948573003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948573003/40001
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948573003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948573003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/1948573003/#ps60001 (title: "Finish sweeping before checking invariants")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948573003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948573003/60001
Message was sent while issue was closed.
Description was changed from ========== [heap] Add regression test for chromium:598319 BUG=chromium:598319 LOG=N ========== to ========== [heap] Add regression test for chromium:598319 BUG=chromium:598319 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Add regression test for chromium:598319 BUG=chromium:598319 LOG=N ========== to ========== [heap] Add regression test for chromium:598319 BUG=chromium:598319 LOG=N Committed: https://crrev.com/07c72af0d7c66ec0e7baad3e72b6b74a8feb7477 Cr-Commit-Position: refs/heads/master@{#36011} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/07c72af0d7c66ec0e7baad3e72b6b74a8feb7477 Cr-Commit-Position: refs/heads/master@{#36011} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
