App icon from subfolder appears in the wrong place when pinning to shelf

App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.
Add an statement AnimateToIdealBounds() will fix this issue.

BUG=605793
Committed: https://crrev.com/926d3e99cd7545146116b40737c34e2b1e66a66b
Cr-Commit-Position: refs/heads/master@{#391979}

[Qiang(Joe) Xu, 2016-05-05 03:04:04]

Description was changed from

==========
App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.

BUG=605793
==========

to

==========
App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.
Add an statement AnimateToIdealBounds() will fix this issue.

BUG=605793
==========

[Qiang(Joe) Xu, 2016-05-05 03:04:12]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 03:04:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948543005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948543005/1

[commit-bot: I haz the power, 2016-05-05 03:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 03:49:27]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2016-05-05 16:49:03]

warx@chromium.org changed reviewers:
+ skuhne@chromium.org

[Mr4D (OOO till 08-26), 2016-05-05 17:03:10]

lgtm

[Mr4D (OOO till 08-26), 2016-05-05 17:03:39]

Would it be possible to add a unit test for this behavior?

[Qiang(Joe) Xu, 2016-05-05 17:15:44]

On 2016/05/05 17:03:39, Mr4D wrote:
> Would it be possible to add a unit test for this behavior?

Maybe. I need to be familiar with shelf_view_unittest.cc first.
Will this block this bug, or can be filed as a separate issue? What do you
think?
Thanks!

[Mr4D (OOO till 08-26), 2016-05-05 17:38:41]

Would be really nice to do it together... :)

Since the testing framework does already exist this should be fairly simple to
do.

[Qiang(Joe) Xu, 2016-05-05 17:41:49]

On 2016/05/05 17:38:41, Mr4D wrote:
> Would be really nice to do it together... :)
> 
> Since the testing framework does already exist this should be fairly simple to
> do.

OK. Will do it.

[Qiang(Joe) Xu, 2016-05-05 22:41:15]

On 2016/05/05 17:41:49, Qiang (Joe) Xu wrote:
> On 2016/05/05 17:38:41, Mr4D wrote:
> > Would be really nice to do it together... :)
> > 
> > Since the testing framework does already exist this should be fairly simple
to
> > do.
> 
> OK. Will do it.

unittest added. Mr4D, could you help take a look? tks.

[Mr4D (OOO till 08-26), 2016-05-06 00:41:11]

lgtm

Many thanks for adding the test!

[Qiang(Joe) Xu, 2016-05-06 00:44:42]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2016-05-06 00:44:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948543005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948543005/40001

[commit-bot: I haz the power, 2016-05-06 01:29:54]

Description was changed from

==========
App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.
Add an statement AnimateToIdealBounds() will fix this issue.

BUG=605793
==========

to

==========
App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.
Add an statement AnimateToIdealBounds() will fix this issue.

BUG=605793
==========

[commit-bot: I haz the power, 2016-05-06 01:29:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-06 01:32:18]

Description was changed from

==========
App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.
Add an statement AnimateToIdealBounds() will fix this issue.

BUG=605793
==========

to

==========
App icon from subfolder appears in the wrong place when pinning to shelf

Bug happens when 1) chrome app is open, 2) it is in overflow bubble (subfolder),
3) pin it to shelf.
Add an statement AnimateToIdealBounds() will fix this issue.

BUG=605793

Committed: https://crrev.com/926d3e99cd7545146116b40737c34e2b1e66a66b
Cr-Commit-Position: refs/heads/master@{#391979}
==========

[commit-bot: I haz the power, 2016-05-06 01:32:19]

Patchset 3 (id:??) landed as
https://crrev.com/926d3e99cd7545146116b40737c34e2b1e66a66b
Cr-Commit-Position: refs/heads/master@{#391979}