build/android/PRESUBMIT.py - Issue 194843003: [Android] Lint the rest of pylib.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/PRESUBMIT.py

Issue 194843003: [Android] Lint the rest of pylib. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no more linting *.py.svn-base files. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | build/android/pylib/android_commands.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for android buildbot.	5 """Presubmit script for android buildbot.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into gcl.

9 """	9 """

10	10

(...skipping 20 matching lines...) Expand all Loading...
31 def CommonChecks(input_api, output_api):	31 def CommonChecks(input_api, output_api):

32 output = []	32 output = []

33	33

34 def J(*dirs):	34 def J(*dirs):

35 """Returns a path relative to presubmit directory."""	35 """Returns a path relative to presubmit directory."""

36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)	36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)

37	37

38 output.extend(input_api.canned_checks.RunPylint(	38 output.extend(input_api.canned_checks.RunPylint(

39 input_api,	39 input_api,

40 output_api,	40 output_api,

41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'],	41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.\.py$', r'pylib/.\.py$'],

	42 black_list=[r'pylib/symbols/.*\.py$'],

42 extra_paths_list=[	43 extra_paths_list=[

43 J(), J('..', '..', 'third_party', 'android_testrunner'),	44 J(), J('..', '..', 'third_party', 'android_testrunner'),

44 J('buildbot')]))	45 J('buildbot')]))

45	46

46 output.extend(input_api.canned_checks.RunUnitTestsInDirectory(	47 output.extend(input_api.canned_checks.RunUnitTestsInDirectory(

47 input_api, output_api, J('buildbot', 'tests')))	48 input_api, output_api, J('buildbot', 'tests')))

48 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))	49 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))

49 return output	50 return output

50	51

51	52

52 def CheckChangeOnUpload(input_api, output_api):	53 def CheckChangeOnUpload(input_api, output_api):

53 return CommonChecks(input_api, output_api)	54 return CommonChecks(input_api, output_api)

54	55

55	56

56 def CheckChangeOnCommit(input_api, output_api):	57 def CheckChangeOnCommit(input_api, output_api):

57 return CommonChecks(input_api, output_api)	58 return CommonChecks(input_api, output_api)

OLD	NEW