Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194843003: [Android] Lint the rest of pylib. (Closed)

Created:
6 years, 9 months ago by jbudorick
Modified:
6 years, 9 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Lint the rest of pylib. BUG=168518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256429

Patch Set 1 #

Patch Set 2 : rebase vs tot #

Patch Set 3 : no more linting *.py.svn-base files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -66 lines) Patch
M build/android/PRESUBMIT.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/android_commands.py View 17 chunks +24 lines, -19 lines 0 comments Download
M build/android/pylib/chrome_test_server_spawner.py View 4 chunks +6 lines, -3 lines 0 comments Download
M build/android/pylib/cmd_helper.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/content_settings.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/device/adb_wrapper_test.py View 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/device_settings.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/flag_changer.py View 2 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/forwarder.py View 5 chunks +8 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_info_collection.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/monkey/setup.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/pexpect.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/ports.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/screenshot.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/pylib/system_properties.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/uiautomator/setup.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 5 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jbudorick
6 years, 9 months ago (2014-03-11 14:20:40 UTC) #1
frankf
lgtm
6 years, 9 months ago (2014-03-11 16:50:53 UTC) #2
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 9 months ago (2014-03-11 18:26:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/194843003/20001
6 years, 9 months ago (2014-03-11 19:14:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 21:53:23 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54729
6 years, 9 months ago (2014-03-11 21:53:24 UTC) #6
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 9 months ago (2014-03-11 22:09:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/194843003/40001
6 years, 9 months ago (2014-03-11 22:34:01 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 04:57:59 UTC) #9
Message was sent while issue was closed. 
Change committed as 256429

Powered by Google App Engine
This is Rietveld 408576698