Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 19484: Fix various problems with constrained windows and/or custom frame windows:... (Closed)

Created:
11 years, 10 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix various problems with constrained windows and/or custom frame windows: * Wrong titlebar height * Titlebars not handling custom font size properly * Drawing errors in maximized mode * One-pixel overlap glitch on bottom corners of client edges * Borders not handling custom border sizes correctly * Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip) * Wrong icon sizing (only a problem in theory, no one uses this code ATM) These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable. BUG=5054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -106 lines) Patch
M chrome/browser/views/constrained_window_impl.cc View 9 chunks +83 lines, -30 lines 0 comments Download
M chrome/views/custom_frame_window.cc View 14 chunks +182 lines, -76 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 10 months ago (2009-01-29 23:41:19 UTC) #1
Ben Goodger (Google)
11 years, 10 months ago (2009-01-30 02:11:42 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698