Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1948383002: Revert of Add CheckAndroidManagement to ARC sign-in flow. (Closed)

Created:
4 years, 7 months ago by elijahtaylor1
Modified:
4 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@check_android_management
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CheckAndroidManagement to ARC sign-in flow. (patchset #18 id:470001 of https://codereview.chromium.org/1892873002/ ) Reason for revert: broken ARC builders Original issue's description: > Add CheckAndroidManagement to ARC sign-in flow. > > ARC is not available for Chrome unmanaged and Android managed accounts. > Check whether account is managed by Android every time on ARC start. > Always allow ARC for managed by Chrome policy and well-known consumer accounts. > > Uncheck ARC checkbox in case of any error. > > BUG=602612 > > TEST=manual > > Committed: https://crrev.com/b7ceb29f22004c344c982e48de1e436834b69274 > Cr-Commit-Position: refs/heads/master@{#391482} TBR=bartfab@chromium.org,xiyuan@chromium.org,khmel@chromium.org,khmel@google.com,pbond@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602612 Committed: https://crrev.com/2a88e4c19ac27fbaa3f8a62359251573b7e16c34 Cr-Commit-Position: refs/heads/master@{#391857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -416 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.h View 5 chunks +1 line, -21 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 13 chunks +18 lines, -108 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.h View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/policy/test/policy_testserver.py View 3 chunks +1 line, -24 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
elijahtaylor1
Created Revert of Add CheckAndroidManagement to ARC sign-in flow.
4 years, 7 months ago (2016-05-05 17:31:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948383002/1
4 years, 7 months ago (2016-05-05 17:31:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 18:51:30 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:53:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a88e4c19ac27fbaa3f8a62359251573b7e16c34
Cr-Commit-Position: refs/heads/master@{#391857}

Powered by Google App Engine
This is Rietveld 408576698