Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1948353004: - Harden code_collection_test against GCs happening at unexpected (Closed)

Created:
4 years, 7 months ago by Ivan Posva
Modified:
4 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Harden code_collection_test against GCs happening at unexpected times. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/71f6e0fe022433bad9ed45ebe887baaf6c1d4aad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/standalone/io/code_collection_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 7 months ago (2016-05-05 21:44:23 UTC) #2
hausner
lgtm
4 years, 7 months ago (2016-05-05 21:49:56 UTC) #3
Ivan Posva
4 years, 7 months ago (2016-05-05 22:09:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71f6e0fe022433bad9ed45ebe887baaf6c1d4aad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698