Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 1948343002: [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (Code changed during CQ Dry-run) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 1b0f33346bcbaecca9e130602f1ebceb2703d623..c4b9d14c8d71540e0479b99ab99c7b6b64482688 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -13,6 +13,7 @@
#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base_observer.h"
+#include "content/browser/renderer_host/text_input_manager.h"
#include "content/common/content_switches_internal.h"
#include "content/public/browser/render_widget_host_view_frame_subscriber.h"
#include "ui/display/display.h"
@@ -40,6 +41,7 @@ RenderWidgetHostViewBase::RenderWidgetHostViewBase()
current_device_scale_factor_(0),
current_display_rotation_(display::Display::ROTATE_0),
pinch_zoom_enabled_(content::IsPinchToZoomEnabled()),
+ text_input_manager_(nullptr),
renderer_frame_number_(0),
weak_factory_(this) {}
@@ -53,6 +55,10 @@ RenderWidgetHostViewBase::~RenderWidgetHostViewBase() {
// NotifyObserversAboutShutdown() twice, as the observers are required to
// de-register on the first call, and so the second call does nothing.
NotifyObserversAboutShutdown();
+ // If we have a live reference to |text_input_manager_|, we should unregister
+ // so that the |text_input_manager_| will free its state.
+ if (text_input_manager_)
+ text_input_manager_->Unregister(this);
}
void RenderWidgetHostViewBase::NotifyObserversAboutShutdown() {
@@ -228,6 +234,13 @@ bool RenderWidgetHostViewBase::HasDisplayPropertyChanged(gfx::NativeView view) {
return true;
}
+void RenderWidgetHostViewBase::DidUnregisterFromTextInputManager(
+ TextInputManager* text_input_manager) {
+ DCHECK(text_input_manager && text_input_manager_ == text_input_manager);
+
+ text_input_manager_ = nullptr;
+}
+
base::WeakPtr<RenderWidgetHostViewBase> RenderWidgetHostViewBase::GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
@@ -388,6 +401,34 @@ void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
*transformed_point = point;
}
+void RenderWidgetHostViewBase::TextInputStateChanged(
+ const TextInputState& text_input_state) {
+// TODO(ekaramad): Use TextInputManager code paths when IME is implemented on
+// other platforms.
+#if defined(USE_AURA)
+ if (GetTextInputManager())
+ GetTextInputManager()->UpdateTextInputState(this, text_input_state);
+#endif
+}
+
+TextInputManager* RenderWidgetHostViewBase::GetTextInputManager() {
+ if (text_input_manager_)
+ return text_input_manager_;
+
+ RenderWidgetHostImpl* host =
+ RenderWidgetHostImpl::From(GetRenderWidgetHost());
+ if (!host || !host->delegate())
+ return nullptr;
+
+ // This RWHV needs to be registered with the TextInputManager so that the
+ // TextInputManager starts tracking its state, and observing its lifetime.
+ text_input_manager_ = host->delegate()->GetTextInputManager();
+ if (text_input_manager_)
+ text_input_manager_->Register(this);
+
+ return text_input_manager_;
+}
+
void RenderWidgetHostViewBase::AddObserver(
RenderWidgetHostViewBaseObserver* observer) {
observers_.AddObserver(observer);
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/renderer_host/text_input_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698