content/browser/web_contents/web_contents_impl.h - Issue 1948343002: [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1948343002: [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using the Destruction Observer for RWHVAura Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/site_per_process_interactive_browsertest.cc ('K') | « content/browser/renderer_host/text_input_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/test/text_input_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index f15c1745b557de368cbab61835559d341c17e793..5603ab3235a8b2063b863c5354be3397801f44d4 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -73,6 +73,7 @@ class SavePackage;

class ScreenOrientationDispatcherHost;

class SiteInstance;

class TestWebContents;

+class TextInputManager;

class WakeLockServiceContext;

class WebContentsAudioMuter;

class WebContentsDelegate;

@@ -631,6 +632,7 @@ class CONTENT_EXPORT WebContentsImpl

const std::vector<uint8_t>& proto) override;

void OnRenderFrameProxyVisibilityChanged(bool visible) override;

void SendScreenRects() override;

+ TextInputManager* GetTextInputManager() override;

// RenderFrameHostManager::Delegate ------------------------------------------

@@ -1374,6 +1376,8 @@ private:

bool page_scale_factor_is_one_;

+ std::unique_ptr<TextInputManager> text_input_manager_;

base::WeakPtrFactory<WebContentsImpl> loading_weak_factory_;

base::WeakPtrFactory<WebContentsImpl> weak_factory_;