Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 1948343002: [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing kenrb@ comments (Removing TextInputManager::Observer::OnTextInputManagerDestroyed) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index dd88faea8fae27b0cfc71207869e299227a5a363..684ccb60138fd747608edc700cdf6bf391be8f86 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -13,6 +13,7 @@
#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base_observer.h"
+#include "content/browser/renderer_host/text_input_manager.h"
#include "content/common/content_switches_internal.h"
#include "content/public/browser/render_widget_host_view_frame_subscriber.h"
#include "ui/display/display.h"
@@ -382,6 +383,29 @@ void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
*transformed_point = point;
}
+void RenderWidgetHostViewBase::TextInputStateChanged(
+ const TextInputState& text_input_state) {
+ if (GetTextInputManager())
+ GetTextInputManager()->UpdateTextInputState(this, text_input_state);
+}
+
+TextInputManager* RenderWidgetHostViewBase::GetTextInputManager() const {
+ RenderWidgetHostImpl* host =
+ RenderWidgetHostImpl::From(GetRenderWidgetHost());
+
+ if (!host || !host->delegate())
+ return nullptr;
+
+ TextInputManager* manager = host->delegate()->GetTextInputManager();
+
+ // If this is the first time getting a reference to this TextInputManager, we
+ // should get it to register this view.
+ if (!manager->IsRegisteredView(this))
+ manager->Register(const_cast<RenderWidgetHostViewBase*>(this));
EhsanK 2016/05/06 18:23:43 I am not sure how OK this is, but the reason for t
+
+ return manager;
+}
+
void RenderWidgetHostViewBase::AddObserver(
RenderWidgetHostViewBaseObserver* observer) {
observers_.AddObserver(observer);

Powered by Google App Engine
This is Rietveld 408576698