[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 47 matching lines @@
 #include "content/browser/media/media_web_contents_observer.h"
 #include "content/browser/media/session/media_session.h"
 #include "content/browser/message_port_message_filter.h"
 #include "content/browser/plugin_content_origin_whitelist.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate_view.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_input_event_router.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
+#include "content/browser/renderer_host/text_input_manager.h"
 #include "content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/wake_lock/wake_lock_service_context.h"
 #include "content/browser/web_contents/web_contents_view_child_frame.h"
 #include "content/browser/web_contents/web_contents_view_guest.h"
 #include "content/browser/webui/generic_handler.h"
 #include "content/browser/webui/web_ui_controller_factory_registry.h"
 #include "content/browser/webui/web_ui_impl.h"
 #include "content/common/browser_plugin/browser_plugin_constants.h"
 #include "content/common/browser_plugin/browser_plugin_messages.h"
@@ skipping 1329 matching lines @@
   render_manager->CreateOuterDelegateProxy(
       outer_contents_frame->GetSiteInstance(),
       static_cast<RenderFrameHostImpl*>(outer_contents_frame));
 
   render_manager->SetRWHViewForInnerContents(
       render_manager->GetRenderWidgetHostView());
 
   static_cast<RenderWidgetHostViewChildFrame*>(
       render_manager->GetRenderWidgetHostView())
       ->RegisterSurfaceNamespaceId();
+
+  // At this point, we should destroy the TextInputManager which will notify all
+  // the RWHV in this WebContents.

[Charlie Reis, 2016/05/18 20:46:05]

What is this accomplishing for the inner WebContents?  I'm not sure I follow
this.

[EhsanK, 2016/05/24 20:42:46]

On line 2376, we return the outer WebContents TextInputManager. If a WebContents
is attached to outer WebContents, its own TextInputManager should be destroyed.

+  // TODO(ekaramad): Is this the right way to for IME handoff? Is it possible to

[Charlie Reis, 2016/05/18 20:46:05]

Not sure I understand this TODO.  (Right way to what?)

[EhsanK, 2016/05/24 20:42:46]

Me neither yet. This only affects OOPIF-<webview> and should be dealt with soon
after OOPIF IME. Traditionally, in BrowserPluginGuest-based <webview>, we call
TextInputStateChanged() on RWHVGuest in some specific occasions. For example,
here when <webview> is focused:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/br...

I am not yet quite certain if the same logic is necessary for OOPIF <webview>.
Two simple scenarios I can think of (not confirm either):
1- We will never have meaningful TextInputState inside inner WebContents before
it is attached. In that case, destroying the TextInputManager is enough.

2- We might have meaningful state, OR, we need to update the state when
<webview> gets focused. I don't know the answer to this yet. 

This should be resolved later (soon after OOPIF) when dealing with
<webview>-IME. Also to clarify, this does not affect non-OOPIF <webview> so
current <webview> IME should be fine as long as OOPIF IME is fine.

+  // have TextInputState (not none) before attaching? If so, we need to restore
+  // it (crbug.com/609846).
+  text_input_manager_.reset(nullptr);
 }
 
 void WebContentsImpl::Stop() {
   for (FrameTreeNode* node : frame_tree_.Nodes())
     node->StopLoading();
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, NavigationStopped());
 }
 
 WebContents* WebContentsImpl::Clone() {
   // We use our current SiteInstance since the cloned entry will use it anyway.
@@ skipping 930 matching lines @@
       static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
   if (rwhv) {
     SendPageMessage(new PageMsg_UpdateWindowScreenRect(
         MSG_ROUTING_NONE, rwhv->GetBoundsInRootWindow()));
   }
 
   if (browser_plugin_embedder_)
     browser_plugin_embedder_->DidSendScreenRects();
 }
 
+TextInputManager* WebContentsImpl::GetTextInputManager() {
+  if (GetOuterWebContents())
+    return GetOuterWebContents()->GetTextInputManager();
+
+  if (!text_input_manager_)
+    text_input_manager_.reset(new TextInputManager());
+
+  return text_input_manager_.get();
+}
+
 BrowserAccessibilityManager*
     WebContentsImpl::GetRootBrowserAccessibilityManager() {
   RenderFrameHostImpl* rfh = GetMainFrame();
   return rfh ? rfh->browser_accessibility_manager() : nullptr;
 }
 
 BrowserAccessibilityManager*
     WebContentsImpl::GetOrCreateRootBrowserAccessibilityManager() {
   RenderFrameHostImpl* rfh = GetMainFrame();
   return rfh ? rfh->GetOrCreateBrowserAccessibilityManager() : nullptr;
@@ skipping 2656 matching lines @@
   for (RenderViewHost* render_view_host : render_view_host_set)
     render_view_host->OnWebkitPreferencesChanged();
 }
 
 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
     JavaScriptDialogManager* dialog_manager) {
   dialog_manager_ = dialog_manager;
 }
 
 }  // namespace content