[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

content/browser/frame_host/interstitial_page_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 11 matching lines @@
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/frame_host/interstitial_page_navigator_impl.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate_view.h"
 #include "content/browser/renderer_host/render_view_host_factory.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
+#include "content/browser/renderer_host/text_input_manager.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/browser/web_contents/web_contents_view.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/interstitial_page_delegate.h"
@@ skipping 882 matching lines @@
 
 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
     const LoadCommittedDetails& load_details) {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
+TextInputManager* InterstitialPageImpl::GetTextInputManager() {

[kenrb, 2016/05/05 20:26:28]

Does this method get called? I don't quite understand what it means to have text
input state on an interstitial page.

[EhsanK, 2016/05/06 18:23:43]

Clicking on the page will cause a TextInputStateChanged call which will then
call the RenderWidgetHostDelegate::GetTextInputManager(). In my earlier draft
from months ago, I tested this (patch:
https://codereview.chromium.org/1663013005/#ps160001) and a lot of tests
actually failed because InterstitialPage where returning nullptr for
TextInputState (bot:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_iso...).

However, I am not sure if there is going to be any meaningful text input state,
now or ever. I think if we can safely ignore those TextInputStateChanged
updates, it is safe to return nullptr. We now do check for GetTextInputManager()
!= nullptr everywhere before asking for GetTextInputState().

[kenrb, 2016/05/12 16:16:36]

Well, it isn't a good thing to create an object that will never be used for
anything, so returning nullptr here sounds likely to be right. If it needs a lot
of test reworking to make that happen then a follow up patch would be
appropriate.

[EhsanK, 2016/05/13 16:00:55]

Makes sense. I don't think it does need a lot of work. If it returns nullptr,
then TextInputState does not get updated. But we should not have text input
inside those pages.

+  if (GetWebContents()) {
+    if (text_input_manager_)
+      text_input_manager_.reset(nullptr);
+
+    return static_cast<WebContentsImpl*>(web_contents_)->GetTextInputManager();
+  }
+
+  if (!text_input_manager_)
+    text_input_manager_.reset(new TextInputManager());
+
+  return text_input_manager_.get();
+}
+
 }  // namespace content