Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 194833002: Customized font value slider to listen for both input and change event (Closed)

Created:
6 years, 9 months ago by Habib Virji
Modified:
6 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Customized font value slider to listen for both input and change event Input type range should listen for both input and change event. Updated code to listen for both input and change event for standard and minimum font type. R=bartfab, jhawkins, tkent BUG=351222 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/options/font_settings.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Habib Virji
Slider thumb change (https://codereview.chromium.org/125973004/) result in listening for both change and input event. Font setting ...
6 years, 9 months ago (2014-03-11 10:19:33 UTC) #1
bartfab (slow)
lgtm
6 years, 9 months ago (2014-03-11 13:41:07 UTC) #2
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 9 months ago (2014-03-11 13:42:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/194833002/1
6 years, 9 months ago (2014-03-11 13:42:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 14:04:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54637
6 years, 9 months ago (2014-03-11 14:04:33 UTC) #6
Dan Beam
lgtm
6 years, 9 months ago (2014-03-11 20:53:38 UTC) #7
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 9 months ago (2014-03-11 21:00:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/194833002/1
6 years, 9 months ago (2014-03-11 21:56:40 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 02:17:45 UTC) #10
Message was sent while issue was closed.
Change committed as 256404

Powered by Google App Engine
This is Rietveld 408576698