Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1948313004: Second try at making MdFocusRing not accept input. (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Second try at making MdFocusRing not accept input. BUG=604344 Committed: https://crrev.com/cee1ce0c107c78e4959c03275462d0177e017443 Cr-Commit-Position: refs/heads/master@{#392095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/views/controls/button/custom_button.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
It would seem being disabled passes mouse move events through but not mouse click events.
4 years, 7 months ago (2016-05-05 21:29:50 UTC) #2
sky
LGTM - I'm tempted to suggest you should have a test case here.
4 years, 7 months ago (2016-05-05 23:24:15 UTC) #3
Evan Stade
On 2016/05/05 23:24:15, sky wrote: > LGTM - I'm tempted to suggest you should have ...
4 years, 7 months ago (2016-05-06 17:58:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948313004/1
4 years, 7 months ago (2016-05-06 17:58:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 18:03:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 18:05:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cee1ce0c107c78e4959c03275462d0177e017443
Cr-Commit-Position: refs/heads/master@{#392095}

Powered by Google App Engine
This is Rietveld 408576698