Remove url scheme from the chooser bubble title

Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521, 529950
Committed: https://crrev.com/295014fabd464fad9af3beca50ad31842fe473fd
Cr-Commit-Position: refs/heads/master@{#394559}

[juncai, 2016-05-05 17:04:31]

Description was changed from

==========
Remove url scheme from the chooser bubble title

The title of the chooser bubble needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521
==========

to

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521
==========

[juncai, 2016-05-05 17:05:22]

Description was changed from

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521
==========

to

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521
==========

[juncai, 2016-05-05 17:06:19]

juncai@chromium.org changed reviewers:
+ palmer@chromium.org

[juncai, 2016-05-05 17:06:19]

Please take a look.

[juncai, 2016-05-05 17:18:11]

Description was changed from

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521
==========

to

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521, 529950
==========

[palmer, 2016-05-06 21:18:08]

https://codereview.chromium.org/1948313003/diff/1/chrome/browser/ui/views/web...
File chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc (right):

https://codereview.chromium.org/1948313003/diff/1/chrome/browser/ui/views/web...
chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc:196:
base::ASCIIToUTF16(controller_->GetOrigin().host()));
We are trying to standardize on FormatUrlForSecurityDisplay (in your case, with
the option OMIT_CRYPTOGRAPHIC). You might need/want to add a version that takes
a url::Origin argument instead of converting the Origin to a GURL.

See components/url_formatter/elide_url.{h,cc}.

[juncai, 2016-05-10 22:40:26]

https://codereview.chromium.org/1948313003/diff/1/chrome/browser/ui/views/web...
File chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc (right):

https://codereview.chromium.org/1948313003/diff/1/chrome/browser/ui/views/web...
chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc:196:
base::ASCIIToUTF16(controller_->GetOrigin().host()));
On 2016/05/06 21:18:08, palmer wrote:
> We are trying to standardize on FormatUrlForSecurityDisplay (in your case,
with
> the option OMIT_CRYPTOGRAPHIC). You might need/want to add a version that
takes
> a url::Origin argument instead of converting the Origin to a GURL.
> 
> See components/url_formatter/elide_url.{h,cc}.

Done.

[juncai, 2016-05-13 23:38:49]

kindly ping, :).

[palmer, 2016-05-18 19:29:47]

lgtm

[juncai, 2016-05-18 20:20:50]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-05-18 20:21:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948313003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948313003/40001

[commit-bot: I haz the power, 2016-05-18 21:45:16]

Description was changed from

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521, 529950
==========

to

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521, 529950
==========

[commit-bot: I haz the power, 2016-05-18 21:45:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 21:47:18]

Description was changed from

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521, 529950
==========

to

==========
Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG=609521, 529950

Committed: https://crrev.com/295014fabd464fad9af3beca50ad31842fe473fd
Cr-Commit-Position: refs/heads/master@{#394559}
==========

[commit-bot: I haz the power, 2016-05-18 21:47:19]

Patchset 3 (id:??) landed as
https://crrev.com/295014fabd464fad9af3beca50ad31842fe473fd
Cr-Commit-Position: refs/heads/master@{#394559}