Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1948303003: Revert of Move about half of the clang/win bots to gn. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Reid Kleckner
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move about half of the clang/win bots to gn. (patchset #1 id:1 of https://codereview.chromium.org/1947183004/ ) Reason for revert: 32-bit builds fail like so: obj/chrome/installer/mini_installer/lib/chrome_appid.obj : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'X86' (The 64-bit bots look fine though.) Original issue's description: > Move about half of the clang/win bots to gn. > > The CrWinClang64(dbg) bot already is on gn. After this change, the > following bots will be on gn: > > Pinned: > CrWinClang > CrWinClang(shared) > CrWinClang64(dbg) (already on gn) > > ToT: > ClangToTWin(dll) > ClangToTWin64 > ClangToTWin64(dll) > > These complement each other, so that each of > - 32-bit release static official > - 32-bit release shared > - 32-bit debug shared > - 64-bit release static official > - 64-bit release shared > - 64-bit debug shared > has one gyp and one gn bot (one a ToT bot, the other a pinned bot, > respectively). > > I'll also switch one of the ASan bots, but that's for a separate CL. > > Hopefully, no behavior change. > > BUG=498033 > R=dpranke@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/dafacdab8ad432c98028eff432c09360f28254fe TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498033 Committed: https://crrev.com/0adf70552c219667ddf4df38752173f8d5dc801b Cr-Commit-Position: refs/heads/master@{#391976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M tools/mb/mb_config.pyl View 8 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
Created Revert of Move about half of the clang/win bots to gn.
4 years, 7 months ago (2016-05-06 01:20:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948303003/1
4 years, 7 months ago (2016-05-06 01:20:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 01:21:30 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0adf70552c219667ddf4df38752173f8d5dc801b Cr-Commit-Position: refs/heads/master@{#391976}
4 years, 7 months ago (2016-05-06 01:22:45 UTC) #6
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-06 01:24:12 UTC) #7
Nico
4 years, 7 months ago (2016-05-06 22:17:52 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1954313002/ by thakis@chromium.org.

The reason for reverting is: 32-bit clang/win/gn builds might work now..

Powered by Google App Engine
This is Rietveld 408576698