Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1948303002: Re-land: Convert the utility process JSON parser into a Mojo service. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Convert the utility process JSON parser into a Mojo service. Original change: https://codereview.chromium.org/1861573002 This change is idential to the original. BUG=597124 TBR=bauerb@chromium.org,sdefresne@chromium.org,tsepez@chromium.org,thakis@chromium.org Committed: https://crrev.com/ab6f6ae93d12cf5913efbb7f1f1f6c34e2cab39b Cr-Commit-Position: refs/heads/master@{#392867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -319 lines) Patch
M chrome/chrome_utility.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
D chrome/utility/safe_json_parser_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/utility/safe_json_parser_handler.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M components/safe_json.gypi View 3 chunks +19 lines, -6 lines 0 comments Download
M components/safe_json/BUILD.gn View 3 chunks +5 lines, -35 lines 0 comments Download
M components/safe_json/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_json/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_json/public/interfaces/safe_json.mojom View 1 chunk +6 lines, -3 lines 0 comments Download
A + components/safe_json/public/interfaces/safe_json.typemap View 1 chunk +4 lines, -7 lines 0 comments Download
M components/safe_json/safe_json_parser_impl.h View 5 chunks +18 lines, -3 lines 0 comments Download
M components/safe_json/safe_json_parser_impl.cc View 3 chunks +52 lines, -31 lines 0 comments Download
D components/safe_json/safe_json_parser_message_filter.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/safe_json/safe_json_parser_message_filter.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D components/safe_json/safe_json_parser_messages.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/safe_json/safe_json_parser_messages.cc View 1 chunk +0 lines, -33 lines 0 comments Download
A + components/safe_json/utility/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
A components/safe_json/utility/safe_json_parser_mojo_impl.h View 1 chunk +35 lines, -0 lines 0 comments Download
A components/safe_json/utility/safe_json_parser_mojo_impl.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A + components/typemaps.gni View 1 chunk +1 line, -4 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948303002/1
4 years, 7 months ago (2016-05-05 07:36:55 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 08:47:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948303002/1
4 years, 7 months ago (2016-05-11 05:35:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 06:39:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948303002/1
4 years, 7 months ago (2016-05-11 06:39:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 06:44:31 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 06:45:42 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ab6f6ae93d12cf5913efbb7f1f1f6c34e2cab39b
Cr-Commit-Position: refs/heads/master@{#392867}

Powered by Google App Engine
This is Rietveld 408576698