Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: src/frames.cc

Issue 19483007: Revert "Addressed danno's comments" and "Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.h ('k') | src/globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
533 533
534 Address ExitFrame::ComputeStackPointer(Address fp) { 534 Address ExitFrame::ComputeStackPointer(Address fp) {
535 return Memory::Address_at(fp + ExitFrameConstants::kSPOffset); 535 return Memory::Address_at(fp + ExitFrameConstants::kSPOffset);
536 } 536 }
537 537
538 538
539 void ExitFrame::FillState(Address fp, Address sp, State* state) { 539 void ExitFrame::FillState(Address fp, Address sp, State* state) {
540 state->sp = sp; 540 state->sp = sp;
541 state->fp = fp; 541 state->fp = fp;
542 state->pc_address = ResolveReturnAddressLocation( 542 state->pc_address = ResolveReturnAddressLocation(
543 reinterpret_cast<Address*>(sp - 1 * kPCOnStackSize)); 543 reinterpret_cast<Address*>(sp - 1 * kPointerSize));
544 } 544 }
545 545
546 546
547 Address StandardFrame::GetExpressionAddress(int n) const { 547 Address StandardFrame::GetExpressionAddress(int n) const {
548 const int offset = StandardFrameConstants::kExpressionsOffset; 548 const int offset = StandardFrameConstants::kExpressionsOffset;
549 return fp() + offset - n * kPointerSize; 549 return fp() + offset - n * kPointerSize;
550 } 550 }
551 551
552 552
553 Object* StandardFrame::GetExpression(Address fp, int index) { 553 Object* StandardFrame::GetExpression(Address fp, int index) {
(...skipping 1042 matching lines...) Expand 10 before | Expand all | Expand 10 after
1596 ZoneList<StackFrame*> list(10, zone); 1596 ZoneList<StackFrame*> list(10, zone);
1597 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1597 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1598 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1598 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1599 list.Add(frame, zone); 1599 list.Add(frame, zone);
1600 } 1600 }
1601 return list.ToVector(); 1601 return list.ToVector();
1602 } 1602 }
1603 1603
1604 1604
1605 } } // namespace v8::internal 1605 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.h ('k') | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698