Issue 19483007: Revert "Addressed danno's comments" and "Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19483007: Revert "Addressed danno's comments" and "Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize… (Closed)

Created:
7 years, 5 months ago by haitao.feng

Modified:
7 years, 5 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Addressed danno's comments" and "Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize constants" BUG=None R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15824

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -91 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/deoptimizer.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/deoptimizer.cc	View	11 chunks	+25 lines, -27 lines	0 comments	Download
M	src/frames.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/frames.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/globals.h	View	1 chunk	+6 lines, -9 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/lithium.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/deoptimizer-mips.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

haitao.feng

I am really sorry that I have used the wrong command to commit these CLs ...

7 years, 5 months ago (2013-07-23 13:28:57 UTC) #1

haitao.feng

7 years, 5 months ago (2013-07-23 13:31:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15824 (presubmit successful).