Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1948283002: Fix gfx::Range::ToString() to use the correct format specifier. (Closed)

Created:
4 years, 7 months ago by karandeepb
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gfx::Range::ToString() to use the correct format specifier. This bug seems to have been introduced in crrev.com/1671403002. Also added a test which fails on the current master. BUG=609359 Committed: https://crrev.com/212a05f54124d15d7678afee40f91219fc90717f Cr-Commit-Position: refs/heads/master@{#391986}

Patch Set 1 #

Patch Set 2 : Add sstream header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ui/gfx/range/range.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/gfx/range/range_unittest.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
karandeepb
PTAL msw@. Thanks.
4 years, 7 months ago (2016-05-05 04:15:10 UTC) #4
msw
lgtm
4 years, 7 months ago (2016-05-05 16:52:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948283002/20001
4 years, 7 months ago (2016-05-06 00:38:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223142)
4 years, 7 months ago (2016-05-06 01:30:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948283002/20001
4 years, 7 months ago (2016-05-06 01:32:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 01:56:57 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 01:58:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/212a05f54124d15d7678afee40f91219fc90717f
Cr-Commit-Position: refs/heads/master@{#391986}

Powered by Google App Engine
This is Rietveld 408576698