PPC: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm me…

PPC: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code.

Port 117a56b7c2a88ab2b2f25fad88517d72f5edbac9

Original commit message:

     - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions.
     - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=gdeepti@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Committed: https://crrev.com/a870cf3abdef044d15e0fc101a7738c433c21e92
Cr-Commit-Position: refs/heads/master@{#36054}

[JaideepBajwa, 2016-05-05 03:04:51]

PTAL

[MTBrandyberry, 2016-05-05 13:33:22]

lgtm

If there is a clean way to address the nit, it would make the code more
efficient.  Perhaps introduce a bool variable that is set differently based on
execution mode.

https://codereview.chromium.org/1948263003/diff/1/src/compiler/ppc/code-gener...
File src/compiler/ppc/code-generator-ppc.cc (right):

https://codereview.chromium.org/1948263003/diff/1/src/compiler/ppc/code-gener...
src/compiler/ppc/code-generator-ppc.cc:1927: if (src.rmode() ==
RelocInfo::WASM_MEMORY_REFERENCE ||
Nit -- on 64-bit this condition will never be true and thus doesn't need to be
checked.

[JaideepBajwa, 2016-05-05 14:01:22]

On 2016/05/05 13:33:22, MTBrandyberry wrote:
> lgtm
> 
> If there is a clean way to address the nit, it would make the code more
> efficient.  Perhaps introduce a bool variable that is set differently based on
> execution mode.
> 
>
https://codereview.chromium.org/1948263003/diff/1/src/compiler/ppc/code-gener...
> File src/compiler/ppc/code-generator-ppc.cc (right):
> 
>
https://codereview.chromium.org/1948263003/diff/1/src/compiler/ppc/code-gener...
> src/compiler/ppc/code-generator-ppc.cc:1927: if (src.rmode() ==
> RelocInfo::WASM_MEMORY_REFERENCE ||
> Nit -- on 64-bit this condition will never be true and thus doesn't need to be
> checked.

PTAL, I've wrapped the if condition around the V8_TARGET_ARCH_PPC64 macro
conditional block.

[john.yan, 2016-05-05 14:04:58]

lgtm

[MTBrandyberry, 2016-05-05 14:06:09]

lgtm

[JaideepBajwa, 2016-05-05 14:06:16]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-05-05 14:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948263003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948263003/20001

[commit-bot: I haz the power, 2016-05-05 19:10:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 19:10:19]

Description was changed from

==========
PPC: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable
pointers to update wasm memory size references in generated code.

Port 117a56b7c2a88ab2b2f25fad88517d72f5edbac9

Original commit message:

     - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and
add relocation information to immediates in compare instructions.
     - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=gdeepti@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N
==========

to

==========
PPC: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable
pointers to update wasm memory size references in generated code.

Port 117a56b7c2a88ab2b2f25fad88517d72f5edbac9

Original commit message:

     - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and
add relocation information to immediates in compare instructions.
     - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=gdeepti@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Committed: https://crrev.com/a870cf3abdef044d15e0fc101a7738c433c21e92
Cr-Commit-Position: refs/heads/master@{#36054}
==========

[commit-bot: I haz the power, 2016-05-05 19:10:20]

Patchset 2 (id:??) landed as
https://crrev.com/a870cf3abdef044d15e0fc101a7738c433c21e92
Cr-Commit-Position: refs/heads/master@{#36054}