Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1948253002: Fix subtyping for generic typedefs. Generic typedefs were being (Closed)

Created:
4 years, 7 months ago by Leaf
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix subtyping for generic typedefs. Generic typedefs were being treated as classes. Fixes https://github.com/dart-lang/dev_compiler/issues/550 . BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1595ff240b43ecb452f373d514a191eb20331cd0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -56 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/browser/runtime_tests.js View 2 chunks +135 lines, -52 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
4 years, 7 months ago (2016-05-05 00:58:34 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-05 01:23:37 UTC) #3
Leaf
4 years, 7 months ago (2016-05-05 01:36:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1595ff240b43ecb452f373d514a191eb20331cd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698