third_party/WebKit/Source/modules/notifications/Notification.h - Issue 1948223004: Introduce the Blink NotificationService, move permission checks there

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1948223004: Introduce the Blink NotificationService, move permission checks there (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn fix, comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/mojo/blink_service_registry_impl.cc ('K') | « third_party/WebKit/Source/modules/modules.gypi ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index cf5c627b6ea058e3acdae6211829e286875ba0bf..0179c470e3f0e1f40b5946110a1000b68a956e7a 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -52,6 +52,7 @@ namespace blink {

class ExecutionContext;

class NotificationAction;

+class NotificationManager;

class NotificationOptions;

class NotificationPermissionCallback;

class NotificationResourcesLoader;

@@ -101,7 +102,6 @@ public:

static String permissionString(mojom::PermissionStatus);

static String permission(ExecutionContext*);

- static mojom::PermissionStatus checkPermission(ExecutionContext*);

static ScriptPromise requestPermission(ScriptState*, NotificationPermissionCallback*);

static size_t maxActions();