content/common/platform_notification_messages.h - Issue 1948223004: Introduce the Blink NotificationService, move permission checks there

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/platform_notification_messages.h

Issue 1948223004: Introduce the Blink NotificationService, move permission checks there (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/platform_notification_context_impl.cc ('K') | « content/child/notifications/notification_manager.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/platform_notification_messages.h

diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h

index dc79fe4fc24dc13a74dd2ca45eb7e7f1fbe889a1..32d1d13b181b21fca315e439c83811a2caf5eba0 100644

--- a/content/common/platform_notification_messages.h

+++ b/content/common/platform_notification_messages.h

@@ -14,7 +14,6 @@

#include "content/public/common/notification_resources.h"

#include "content/public/common/platform_notification_data.h"

#include "ipc/ipc_message_macros.h"

-#include "third_party/WebKit/public/platform/modules/permissions/permission_status.mojom.h"

#include "third_party/skia/include/core/SkBitmap.h"

// Singly-included section for type definitions.

@@ -125,8 +124,3 @@ IPC_MESSAGE_CONTROL1(PlatformNotificationHostMsg_Close,

IPC_MESSAGE_CONTROL2(PlatformNotificationHostMsg_ClosePersistent,

GURL /* origin */,

int64_t /* persistent_notification_id */)

-IPC_SYNC_MESSAGE_CONTROL1_1(

- PlatformNotificationHostMsg_CheckPermission,

- GURL /* origin */,

- blink::mojom::PermissionStatus /* permission_status */)