third_party/WebKit/public/platform/modules/notifications/OWNERS - Issue 1948223004: Introduce the Blink NotificationService, move permission checks there

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/notifications/OWNERS

Issue 1948223004: Introduce the Blink NotificationService, move permission checks there (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: OWNERS + thread jump when connecting Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/notifications/NotificationManager.cpp ('K') | « third_party/WebKit/public/blink.gyp ('k') | third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h » ('j') | third_party/WebKit/public/platform/modules/notifications/notification_service.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 peter@chromium.org	1 peter@chromium.org

	2

	3 # Changes to Mojo interfaces require a security review to avoid

	4 # introducing new sandbox escapes.
	haraken 2016/05/06 00:41:12 dcheng@: Do we need to add this to all modules/X/O dcheng@: Do we need to add this to all modules/X/OWNERS? dcheng 2016/05/06 01:06:36 Yeah. I talked with peter@ and dpranke@ today abou Show quoted text On 2016/05/06 at 00:41:12, haraken wrote: > dcheng@: Do we need to add this to all modules/X/OWNERS? Yeah. I talked with peter@ and dpranke@ today about the changes I'm going to make to owners.py, and I think I have agreement on what to do. So this shouldn't be necessary in a few days.
	5 per-file *.mojom=set noparent

	6 per-file *.mojom=dcheng@chromium.org

	7 per-file *.mojom=inferno@chromium.org

	8 per-file *.mojom=jln@chromium.org

	9 per-file *.mojom=jschuh@chromium.org

	10 per-file *.mojom=kenrb@chromium.org

	11 per-file *.mojom=mkwst@chromium.org

	12 per-file *.mojom=nasko@chromium.org

	13 per-file *.mojom=palmer@chromium.org

	14 per-file *.mojom=tsepez@chromium.org

	15 per-file *.mojom=wfh@chromium.org

OLD	NEW