Chromium Code Reviews
DescriptionRevert of [css-grid] Floated grid containers have indefinite width (patchset #1 id:1 of https://codereview.chromium.org/1892813002/ )
Reason for revert:
This is breaking how percentages work in
Flexbox and Grid compared to regular Blocks.
There're some discussion ongoing on the CSS WG to verify
the expected behavior, so we're reverting this for now
until we've a final resolution.
Original issue's description:
> [css-grid] Floated grid containers have indefinite width
>
> Fix LayoutBox::hasDefiniteLogicalWidth() to return FALSE for
> floated grid containers with auto width.
>
> This makes that percentage tracks are treated as "auto"
> for floated grid containers with indefinite width.
>
> BUG=603854
> TEST=fast/css-grid-layout/floated-grid-container-percentage-tracks.html
>
> Committed: https://crrev.com/a7f443f6a36a2a524c4c29a2ef1bb6d02249d7b2
> Cr-Commit-Position: refs/heads/master@{#388054}
TBR=cbiesinger@chromium.org,mstensho@opera.com,svillar@igalia.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=538513, 603854, 604346, 608783
Committed: https://crrev.com/ec80ed8bf97986c752629bd0a550800fbe8bd82b
Cr-Commit-Position: refs/heads/master@{#391782}
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
||||||||||||||||||||||||||||