Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1948203004: Revert of [css-grid] Floated grid containers have indefinite width (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [css-grid] Floated grid containers have indefinite width (patchset #1 id:1 of https://codereview.chromium.org/1892813002/ ) Reason for revert: This is breaking how percentages work in Flexbox and Grid compared to regular Blocks. There're some discussion ongoing on the CSS WG to verify the expected behavior, so we're reverting this for now until we've a final resolution. Original issue's description: > [css-grid] Floated grid containers have indefinite width > > Fix LayoutBox::hasDefiniteLogicalWidth() to return FALSE for > floated grid containers with auto width. > > This makes that percentage tracks are treated as "auto" > for floated grid containers with indefinite width. > > BUG=603854 > TEST=fast/css-grid-layout/floated-grid-container-percentage-tracks.html > > Committed: https://crrev.com/a7f443f6a36a2a524c4c29a2ef1bb6d02249d7b2 > Cr-Commit-Position: refs/heads/master@{#388054} TBR=cbiesinger@chromium.org,mstensho@opera.com,svillar@igalia.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=538513, 603854, 604346, 608783 Committed: https://crrev.com/ec80ed8bf97986c752629bd0a550800fbe8bd82b Cr-Commit-Position: refs/heads/master@{#391782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -100 lines) Patch
D third_party/WebKit/LayoutTests/fast/css-grid-layout/floated-grid-container-percentage-tracks.html View 1 chunk +0 lines, -99 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Manuel Rego
Created Revert of [css-grid] Floated grid containers have indefinite width
4 years, 7 months ago (2016-05-05 07:15:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948203004/1
4 years, 7 months ago (2016-05-05 07:16:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 09:35:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec80ed8bf97986c752629bd0a550800fbe8bd82b Cr-Commit-Position: refs/heads/master@{#391782}
4 years, 7 months ago (2016-05-05 09:36:57 UTC) #8
cbiesinger
4 years, 7 months ago (2016-05-05 13:37:06 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698