Fix math min/max for -0.0 case. Enable min_max_test to run in optimizing compiler as well.

runtime/vm/intermediate_language_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_MIPS.
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 3076 matching lines @@
 
 LocationSummary* MathMinMaxInstr::MakeLocationSummary() const {
   if (result_cid() == kDoubleCid) {
     const intptr_t kNumInputs = 2;
     const intptr_t kNumTemps = 1;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RequiresFpuRegister());
     summary->set_in(1, Location::RequiresFpuRegister());
     summary->set_out(Location::RequiresFpuRegister());
+    summary->set_temp(0, Location::RequiresRegister());
     return summary;
   }
   ASSERT(result_cid() == kSmiCid);
   UNIMPLEMENTED();
   return NULL;
 }
 
 
 void MathMinMaxInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  ASSERT((op_kind() == MethodRecognizer::kMathMin) ||
+         (op_kind() == MethodRecognizer::kMathMax));
   if (result_cid() == kDoubleCid) {
-    Label done, is_nan, is_left;
+    Label done, returns_nan, returns_left, are_equal;
     DRegister left = locs()->in(0).fpu_reg();
     DRegister right = locs()->in(1).fpu_reg();
     DRegister result = locs()->out().fpu_reg();
+    Register temp = locs()->temp(0).reg();
     __ cund(left, right);
-    __ bc1t(&is_nan);
-    if (op_kind() == MethodRecognizer::kMathMin) {
+    __ bc1t(&returns_nan);
+    __ ceqd(left, right);
+    __ bc1t(&are_equal);
+    const intptr_t is_min = (op_kind() == MethodRecognizer::kMathMin);
+    if (is_min) {
       __ coltd(left, right);
     } else {
-      ASSERT(op_kind() == MethodRecognizer::kMathMax);
       __ coltd(right, left);
     }
     // TODO(zra): Add conditional moves.
-    __ bc1t(&is_left);
+    __ bc1t(&returns_left);
     __ movd(result, right);
     __ b(&done);
-    __ Bind(&is_left);
+
+    __ Bind(&returns_left);
     __ movd(result, right);
     __ b(&done);
-    __ Bind(&is_nan);
+
+    __ Bind(&returns_nan);
     __ LoadImmediate(result, NAN);
+    __ b(&done);
+
+    __ Bind(&are_equal);
+    Label left_is_negative;
+    // Check for negative zero: -0.0 is equal 0.0 but min or max must return
+    // -0.0 or 0.0 respectively.
+    // Check for negative left value (get the sign bit):
+    // - min -> left is negative ? left : right.
+    // - max -> left is negative ? right : left
+    // Check the sign bit.
+    __ mfc1(temp, OddFRegisterOf(left));  // Moves bits 32...63 of left to temp.
+    __ srl(temp, temp, 31);  // Get the sign bit down to bit 0.
+    __ andi(CMPRES, temp, Immediate(1));  // Check if the bit is set.

[regis, 2013/07/22 20:55:11]

You do not need the 2 instructions above. Use bltz for the conditional branch
below.

[srdjan, 2013/07/22 21:10:16]

Done.

+    // NE -> Sign bit set.
+    __ bne(temp, ZR, &left_is_negative);  // Sign bit set.
+    // Left is positive.
+    __ movd(result, (is_min ? right : left));
+    __ b(&done);
+
+    __ Bind(&left_is_negative);
+    __ movd(result, (is_min ? left : right));
     __ Bind(&done);
     return;
   }
   ASSERT(result_cid() == kSmiCid);
   UNIMPLEMENTED();
 }
 
 
 LocationSummary* UnarySmiOpInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
@@ skipping 683 matching lines @@
   compiler->GenerateCall(token_pos(),
                          &label,
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS