Change Android client desktop panning and zooming behavior

Change Android client desktop panning and zooming behavior

It's now possible to scroll out far enough to see the entire desktop. Scrolling out all the way centers the image, nesting it between two black bars of equal length.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212964

[solb, 2013-07-20 05:17:01]

This CL brings interface improvements to the remote desktop viewer portion of
the app.

[garykac, 2013-07-20 21:10:43]

lgtm

https://codereview.chromium.org/19482019/diff/2004/remoting/android/java/src/...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/19482019/diff/2004/remoting/android/java/src/...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:142: //
screen, the user is attempting to scroll into a blank area of the canvas.
These comments (here and above) seem indented strangely.

https://codereview.chromium.org/19482019/diff/2004/remoting/android/java/src/...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:157: else { 
// Updating this value during an attempt to scroll away causes oscillation.
If these comments apply to the line below, then they shouldn't be a line comment
on the "else" token.

Also, the comment seems to imply a TODO to address the oscillation.

[garykac, 2013-07-20 21:11:25]

Oops. didn't mean to lgtm it just yet.

[solb, 2013-07-21 08:18:06]

Although I'm responding now, I don't have a chance to fix this tonight. Thanks
for the weekend review, though!

https://codereview.chromium.org/19482019/diff/2004/remoting/android/java/src/...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/19482019/diff/2004/remoting/android/java/src/...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:142: //
screen, the user is attempting to scroll into a blank area of the canvas.
On 2013/07/20 21:10:44, garykac wrote:
> These comments (here and above) seem indented strangely.

Okay; I'll bump them out one level.

https://codereview.chromium.org/19482019/diff/2004/remoting/android/java/src/...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:157: else { 
// Updating this value during an attempt to scroll away causes oscillation.
On 2013/07/20 21:10:44, garykac wrote:
> If these comments apply to the line below, then they shouldn't be a line
comment
> on the "else" token.
> 
> Also, the comment seems to imply a TODO to address the oscillation.

Actually, this comment was intended to explain the placement of that line inside
an else as opposed to simply following the if block, where it would exhibit the
described behavior. I'll try to reword it in a way that expresses this more
clearly.

[commit-bot: I haz the power, 2013-07-22 18:03:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/solb@chromium.org/19482019/12001

[commit-bot: I haz the power, 2013-07-22 21:03:55]

Change committed as 212964