Issue 1948183002: Add Dart_IsPrecompiledRuntime to help simplify logic in embedders that conditionally use precompila…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1948183002: Add Dart_IsPrecompiledRuntime to help simplify logic in embedders that conditionally use precompila… (Closed)

Created:
4 years, 7 months ago by rmacnak

Modified:
4 years, 7 months ago

Reviewers:
Florian Schneider, Chinmay

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add Dart_IsPrecompiledRuntime to help simplify logic in embedders that conditionally use precompilation or the JIT. R=chinmaygarde@google.com Committed: https://github.com/dart-lang/sdk/commit/354a26ce5295df60cd3757cf9e5031b219907d1a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -2 lines)			Patch
	M	runtime/include/dart_api.h	View	1 2	2 chunks	+38 lines, -2 lines	0 comments	Download
	M	runtime/vm/dart_api_impl.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Chinmay

On 2016/05/04 at 23:41:23, rmacnak wrote: > lgtm. Thanks for the clarification with the comments.

4 years, 7 months ago (2016-05-04 23:45:22 UTC) #3

rmacnak

4 years, 7 months ago (2016-05-05 18:32:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
354a26ce5295df60cd3757cf9e5031b219907d1a (presubmit successful).