Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1948143003: Add null check to ToolbarControlContainer#getProgressBarDrawingInfo() (Closed)

Created:
4 years, 7 months ago by Theresa
Modified:
4 years, 7 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check to ToolbarControlContainer#getProgressBarDrawingInfo() We are seeing crash reports due to an NPE in this method caused by getProgressBar() returning null. BUG=604616 Committed: https://crrev.com/c2a8fa9c3c33a201f06cdfaf40322f84f5dd6519 Cr-Commit-Position: refs/heads/master@{#391960}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix line breaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Theresa
ptal
4 years, 7 months ago (2016-05-04 23:57:55 UTC) #2
Yusuf
lgtm https://codereview.chromium.org/1948143003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java File chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java (right): https://codereview.chromium.org/1948143003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java#newcode62 chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java:62: if (progressBar != null) { fits in one ...
4 years, 7 months ago (2016-05-05 22:24:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948143003/20001
4 years, 7 months ago (2016-05-05 23:12:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 00:19:02 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 00:20:38 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c2a8fa9c3c33a201f06cdfaf40322f84f5dd6519
Cr-Commit-Position: refs/heads/master@{#391960}

Powered by Google App Engine
This is Rietveld 408576698