Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1948133004:
CWS Private API - isPendingCustodianApproval (Closed)
|
Created:
4 years, 7 months ago by mamir Modified:
4 years, 5 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@kid_initiated_install Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCWS private API (webstorePrivate.isPendingCustodianApproval)
Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval)
to check if an extension is pending custodian approval. It is used in
the wesbtore to show the extension as "Pending" when it has been installed
or updated and the custodian hasn't approved it yet.
Custodian approvals are required for extensions that are installed by
supervised users and Unicorn users, or for updates that require additional
permissions.
BUG=609849
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/f7715a2ae33d1bcc0515b47254c305e47d0b6a18
Cr-Commit-Position: refs/heads/master@{#403674}
Patch Set 1 #Patch Set 2 : Revet a wrongly committed file (build/update-linux-sandbox.sh) #Patch Set 3 : Now, it compiles. #Patch Set 4 : Adding unittests #
Total comments: 12
Patch Set 5 : Fixing nits about coding style. #
Total comments: 10
Patch Set 6 : Respond to 2nd round of comments from treib@ #
Total comments: 4
Patch Set 7 : Response to 3rd round of comments by treib@ #Patch Set 8 : rebasing #Patch Set 9 : rebasing and modifyig some tests #
Total comments: 2
Patch Set 10 : Response to code review by Marc #
Total comments: 2
Patch Set 11 : Response to code review by Marc #
Total comments: 4
Patch Set 12 : Response to code review by Antony #Patch Set 13 : rebasing #
Messages
Total messages: 46 (19 generated)
Description was changed from ========== updaint the histogram Adding a new CWS private API to check if an extension is pending custodian approval or not BUG= ========== to ========== Adding a new CWS private API to check if an extension is pending custodian approval or no. BUG=609849 ==========
mamir@chromium.org changed reviewers: + treib@chromium.org
I have added couple of Unit test for the new API.
A bunch of style nits below; one actual question: Might we ever want to call this function from the dashboard? If so, it should go into dashboardPrivate instead of webstorePrivate. https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:628: EXTENSION_FUNCTION_VALIDATE(params); I'd validate the args before checking IsSupervised, for better coverage if someone passes in invalid args. https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:638: ExtensionPrefs* extensionsPrefs = ExtensionPrefs::Get(browser_context()); extension_prefs https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:651: extensions::Extension::DISABLE_CUSTODIAN_APPROVAL_REQUIRED)))); extensions:: isn't required, we're already in that namespace (also above) https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... File chrome/browser/extensions/extension_service_sync_unittest.cc (right): https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/extension_service_sync_unittest.cc:1588: bool isExtensionPendingCustodianApproval(const std::string& extensionId) { "Is..", capitalized. Also extension_id https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... File chrome/common/extensions/api/webstore_private.json (right): https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... chrome/common/extensions/api/webstore_private.json:323: "description": "Checks if an extensions installed on a Supervised User profiles is pending custodian approval or not.", nit: "extension" and "profile", singular. I'd also drop the "or not". https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... chrome/common/extensions/api/webstore_private.json:328: "description": "The extension id of the extensions to be checked." Also here: "extension"
On 2016/05/09 11:50:19, Marc Treib wrote: > A bunch of style nits below; one actual question: Might we ever want to call > this function from the dashboard? If so, it should go into dashboardPrivate > instead of webstorePrivate. > > https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... > File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc > (right): > > https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... > chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:628: > EXTENSION_FUNCTION_VALIDATE(params); > I'd validate the args before checking IsSupervised, for better coverage if > someone passes in invalid args. > > https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... > chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:638: > ExtensionPrefs* extensionsPrefs = ExtensionPrefs::Get(browser_context()); > extension_prefs > > https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... > chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:651: > extensions::Extension::DISABLE_CUSTODIAN_APPROVAL_REQUIRED)))); > extensions:: isn't required, we're already in that namespace (also above) > > https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... > File chrome/browser/extensions/extension_service_sync_unittest.cc (right): > > https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... > chrome/browser/extensions/extension_service_sync_unittest.cc:1588: bool > isExtensionPendingCustodianApproval(const std::string& extensionId) { > "Is..", capitalized. > Also extension_id > > https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... > File chrome/common/extensions/api/webstore_private.json (right): > > https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... > chrome/common/extensions/api/webstore_private.json:323: "description": "Checks > if an extensions installed on a Supervised User profiles is pending custodian > approval or not.", > nit: "extension" and "profile", singular. I'd also drop the "or not". > > https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... > chrome/common/extensions/api/webstore_private.json:328: "description": "The > extension id of the extensions to be checked." > Also here: "extension" I don't think we may need to call this function from the dashboard. The dashboard is used by custodians, while this function checks an installed extension.
https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:628: EXTENSION_FUNCTION_VALIDATE(params); On 2016/05/09 11:50:19, Marc Treib wrote: > I'd validate the args before checking IsSupervised, for better coverage if > someone passes in invalid args. Done. https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:638: ExtensionPrefs* extensionsPrefs = ExtensionPrefs::Get(browser_context()); On 2016/05/09 11:50:19, Marc Treib wrote: > extension_prefs Sorry! Done! https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:651: extensions::Extension::DISABLE_CUSTODIAN_APPROVAL_REQUIRED)))); On 2016/05/09 11:50:19, Marc Treib wrote: > extensions:: isn't required, we're already in that namespace (also above) Done. https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... File chrome/browser/extensions/extension_service_sync_unittest.cc (right): https://codereview.chromium.org/1948133004/diff/60001/chrome/browser/extensio... chrome/browser/extensions/extension_service_sync_unittest.cc:1588: bool isExtensionPendingCustodianApproval(const std::string& extensionId) { On 2016/05/09 11:50:19, Marc Treib wrote: > "Is..", capitalized. > Also extension_id Done. https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... File chrome/common/extensions/api/webstore_private.json (right): https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... chrome/common/extensions/api/webstore_private.json:323: "description": "Checks if an extensions installed on a Supervised User profiles is pending custodian approval or not.", On 2016/05/09 11:50:19, Marc Treib wrote: > nit: "extension" and "profile", singular. I'd also drop the "or not". Done. https://codereview.chromium.org/1948133004/diff/60001/chrome/common/extension... chrome/common/extensions/api/webstore_private.json:328: "description": "The extension id of the extensions to be checked." On 2016/05/09 11:50:19, Marc Treib wrote: > Also here: "extension" Done.
https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:642: params->id, extensions::Extension::DISABLE_PERMISSIONS_INCREASE)) { Also here: extensions:: not required. https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:649: extensions_prefs->HasDisableReason( nit: A four-line statement seems a bit excessive... pull the HasDisableReason call out into a separate statement? https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.h (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.h:295: "webstorePrivate.isExtensionCustodianPendingApproval", isExtensionPendingCustodianApproval https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/extension_service_sync_unittest.cc (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/extension_service_sync_unittest.cc:1591: WebstorePrivateIsExtensionPendingCustodianApprovalFunction(), This looks like it'd create a memleak?
https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:642: params->id, extensions::Extension::DISABLE_PERMISSIONS_INCREASE)) { On 2016/05/09 13:44:57, Marc Treib wrote: > Also here: extensions:: not required. Done. https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:649: extensions_prefs->HasDisableReason( On 2016/05/09 13:44:56, Marc Treib wrote: > nit: A four-line statement seems a bit excessive... pull the HasDisableReason > call out into a separate statement? Done. https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.h (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.h:295: "webstorePrivate.isExtensionCustodianPendingApproval", On 2016/05/09 13:44:57, Marc Treib wrote: > isExtensionPendingCustodianApproval Done. https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/extension_service_sync_unittest.cc (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/extension_service_sync_unittest.cc:1591: WebstorePrivateIsExtensionPendingCustodianApprovalFunction(), On 2016/05/09 13:44:57, Marc Treib wrote: > This looks like it'd create a memleak? Done.
https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.h (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.h:295: "webstorePrivate.isExtensionCustodianPendingApproval", On 2016/05/09 14:42:19, mamir wrote: > On 2016/05/09 13:44:57, Marc Treib wrote: > > isExtensionPendingCustodianApproval > > Done. No. Please proofread your code. https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:647: bool isPendingApproval = extensions_prefs->HasDisableReason( is_pending_approval https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... File chrome/browser/extensions/extension_service_sync_unittest.cc (right): https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... chrome/browser/extensions/extension_service_sync_unittest.cc:1591: function( You could do auto function = make_scoped_refptr(new ...) to save some characters. Also maybe using extensions::WebstorePrivateIsExtensionPendingCustodianApprovalFunction; above if that saves a line break.
https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... File chrome/browser/extensions/api/webstore_private/webstore_private_api.h (right): https://codereview.chromium.org/1948133004/diff/80001/chrome/browser/extensio... chrome/browser/extensions/api/webstore_private/webstore_private_api.h:295: "webstorePrivate.isExtensionCustodianPendingApproval", On 2016/05/09 14:50:57, Marc Treib wrote: > On 2016/05/09 14:42:19, mamir wrote: > > On 2016/05/09 13:44:57, Marc Treib wrote: > > > isExtensionPendingCustodianApproval > > > > Done. > > No. Please proofread your code. Sorry! Done. https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:647: bool isPendingApproval = extensions_prefs->HasDisableReason( On 2016/05/09 14:50:57, Marc Treib wrote: > is_pending_approval Sorry, again! Done. https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... File chrome/browser/extensions/extension_service_sync_unittest.cc (right): https://codereview.chromium.org/1948133004/diff/100001/chrome/browser/extensi... chrome/browser/extensions/extension_service_sync_unittest.cc:1591: function( On 2016/05/09 14:50:57, Marc Treib wrote: > You could do > auto function = make_scoped_refptr(new ...) > to save some characters. Also maybe > using extensions::WebstorePrivateIsExtensionPendingCustodianApprovalFunction; > above if that saves a line break. Done.
LGTM! (I'd wait for the other CL to land before sending this for further review.) Please update the CL description, e.g. mention the actual name of the new function (webstorePrivate.is...), and put the CL title into the description as well - after landing, only the description will survive.
Description was changed from ========== Adding a new CWS private API to check if an extension is pending custodian approval or no. BUG=609849 ========== to ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. BUG=609849 ==========
Description was changed from ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. BUG=609849 ========== to ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Patchset #8 (id:140001) has been deleted
Description was changed from ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. Custodian approvals are required for extensions that are installed by supervised users and Unicorn users, or for updates that require additional permissions. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by mamir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
mamir@chromium.org changed reviewers: + asargent@chromium.org
asargent@chromium.org: Please review changes in webstore private api related files! Thank you.
https://codereview.chromium.org/1948133004/diff/180001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/180001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:609: IsExtensionPendingCustodianApproval::Results::Create(false))); nit: Maybe create a helper method "Respond(bool result)"?
https://codereview.chromium.org/1948133004/diff/180001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/180001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:609: IsExtensionPendingCustodianApproval::Results::Create(false))); On 2016/06/29 08:23:12, Marc Treib wrote: > nit: Maybe create a helper method "Respond(bool result)"? I created a BuildResponse method instead to be consistent with surrounding code. Done!
The CQ bit was checked by mamir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks, LGTM with one more nit https://codereview.chromium.org/1948133004/diff/200001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.h (right): https://codereview.chromium.org/1948133004/diff/200001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.h:308: ExtensionFunction::ResponseValue BuildResponse(bool result); Methods go before members
https://codereview.chromium.org/1948133004/diff/200001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.h (right): https://codereview.chromium.org/1948133004/diff/200001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.h:308: ExtensionFunction::ResponseValue BuildResponse(bool result); On 2016/06/29 12:01:09, Marc Treib wrote: > Methods go before members Ooops, sorry. Done!
lgtm https://codereview.chromium.org/1948133004/diff/220001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/220001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:636: return ArgumentList( can this be OneArgument instead of ArgumentList? https://codereview.chromium.org/1948133004/diff/220001/chrome/common/extensio... File chrome/common/extensions/api/webstore_private.json (right): https://codereview.chromium.org/1948133004/diff/220001/chrome/common/extensio... chrome/common/extensions/api/webstore_private.json:322: "name": "isExtensionPendingCustodianApproval", optional naming suggestion: "isPendingCustodianApproval" would convey pretty much the same meaning (especially given the id argument that's documented to be an extension id), but be 9 characters shorter.
https://codereview.chromium.org/1948133004/diff/220001/chrome/browser/extensi... File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://codereview.chromium.org/1948133004/diff/220001/chrome/browser/extensi... chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:636: return ArgumentList( On 2016/06/29 20:50:52, Antony Sargent wrote: > can this be OneArgument instead of ArgumentList? Done. https://codereview.chromium.org/1948133004/diff/220001/chrome/common/extensio... File chrome/common/extensions/api/webstore_private.json (right): https://codereview.chromium.org/1948133004/diff/220001/chrome/common/extensio... chrome/common/extensions/api/webstore_private.json:322: "name": "isExtensionPendingCustodianApproval", On 2016/06/29 20:50:52, Antony Sargent wrote: > optional naming suggestion: "isPendingCustodianApproval" would convey pretty > much the same meaning (especially given the id argument that's documented to be > an extension id), but be 9 characters shorter. Done.
mamir@chromium.org changed reviewers: + holte@chromium.org, isherman@chromium.org
Hi isherman@chromium.org, Please, review changes in extensions/browser/extension_function_histogram_value.h Hi holte@chromium.org Please, review changes in tools/metrics/histograms/histograms.xml
extensions/browser/extension_function_histogram_value.h and tools/metrics/histograms/histograms.xml LGTM
Patchset #13 (id:260001) has been deleted
Patchset #13 (id:280001) has been deleted
The CQ bit was checked by mamir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mamir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org, asargent@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1948133004/#ps300001 (title: "rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. Custodian approvals are required for extensions that are installed by supervised users and Unicorn users, or for updates that require additional permissions. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. Custodian approvals are required for extensions that are installed by supervised users and Unicorn users, or for updates that require additional permissions. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #13 (id:300001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. Custodian approvals are required for extensions that are installed by supervised users and Unicorn users, or for updates that require additional permissions. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== CWS private API (webstorePrivate.isPendingCustodianApproval) Adding a new CWS private API (webstorePrivate.isPendingCustodianApproval) to check if an extension is pending custodian approval. It is used in the wesbtore to show the extension as "Pending" when it has been installed or updated and the custodian hasn't approved it yet. Custodian approvals are required for extensions that are installed by supervised users and Unicorn users, or for updates that require additional permissions. BUG=609849 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f7715a2ae33d1bcc0515b47254c305e47d0b6a18 Cr-Commit-Position: refs/heads/master@{#403674} ==========
Message was sent while issue was closed.
Patchset 13 (id:??) landed as https://crrev.com/f7715a2ae33d1bcc0515b47254c305e47d0b6a18 Cr-Commit-Position: refs/heads/master@{#403674} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
