Add codegen support in smoke

pkg/smoke/test/codegen/generator_test.dart

Index: pkg/smoke/test/codegen/generator_test.dart
diff --git a/pkg/smoke/test/codegen/generator_test.dart b/pkg/smoke/test/codegen/generator_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..a17172d29888f6bc79ea68ecae8abd5f81d2d119
--- /dev/null
+++ b/pkg/smoke/test/codegen/generator_test.dart
@@ -0,0 +1,188 @@
+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library smoke.test.codegen.generator_test;
+
+import 'package:smoke/codegen/generator.dart';
+import 'package:unittest/unittest.dart';
+
+main() {
+  test('getters', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addGetter('i');
+    _checkResults(generator, initCall:
+        'useGeneratedCode(new StaticConfiguration(\n'
+        '    checkedMode: false,\n'
+        '    getters: {\n'
+        '      #i: (o) => o.i,\n'
+        '    }));\n');
+
+    generator.addGetter('foo');
+    _checkResults(generator, initCall:
+        'useGeneratedCode(new StaticConfiguration(\n'
+        '    checkedMode: false,\n'
+        '    getters: {\n'
+        '      #foo: (o) => o.foo,\n'
+        '      #i: (o) => o.i,\n'
+        '    }));\n');
+  });
+
+  test('setters', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addSetter('i');
+    _checkResults(generator, initCall:
+        'useGeneratedCode(new StaticConfiguration(\n'
+        '    checkedMode: false,\n'
+        '    setters: {\n'
+        '      #i: (o, v) { o.i = v; },\n'
+        '    }));\n');
+
+    generator.addSetter('foo');
+    _checkResults(generator, initCall:
+        'useGeneratedCode(new StaticConfiguration(\n'
+        '    checkedMode: false,\n'
+        '    setters: {\n'
+        '      #foo: (o, v) { o.foo = v; },\n'
+        '      #i: (o, v) { o.i = v; },\n'
+        '    }));\n');
+  });
+
+  test('names/symbols', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addSymbol('i');
+    generator.addSymbol('foo');
+    _checkResults(generator, initCall:
+        'useGeneratedCode(new StaticConfiguration(\n'
+        '    checkedMode: false,\n'
+        '    names: {\n'
+        '      #foo: \'foo\',\n'
+        '      #i: \'i\',\n'
+        '    }));\n');
+  });
+
+  test('getters, setters, and names', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addGetter('i');
+    generator.addSetter('i');
+    generator.addSetter('foo');
+    generator.addSymbol('foo');
+    _checkResults(generator, initCall:
+        'useGeneratedCode(new StaticConfiguration(\n'
+        '    checkedMode: false,\n'
+        '    getters: {\n'
+        '      #i: (o) => o.i,\n'
+        '    },\n'
+        '    setters: {\n'
+        '      #foo: (o, v) { o.foo = v; },\n'
+        '      #i: (o, v) { o.i = v; },\n'
+        '    },\n'
+        '    names: {\n'
+        '      #foo: \'foo\',\n'
+        '    }));\n');
+  });
+
+  test('parents', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addParent(new TypeIdentifier('a.dart', 'A'),
+        new TypeIdentifier('b.dart', 'B'));
+    generator.addParent(new TypeIdentifier('a.dart', 'C'),
+        new TypeIdentifier('a.dart', 'A'));
+    _checkResults(generator,
+        imports: [
+          "import 'a.dart' as smoke_0;",
+          "import 'b.dart' as smoke_1;"
+        ],
+        initCall:
+          'useGeneratedCode(new StaticConfiguration(\n'
+          '    checkedMode: false,\n'
+          '    parents: {\n'
+          '      smoke_0.A: smoke_1.B,\n'
+          '      smoke_0.C: smoke_0.A,\n'
+          '    }));\n');
+  });
+
+  test('declarations', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addDeclaration(new TypeIdentifier('a.dart', 'A'), 'foo',
+        new TypeIdentifier('dart:core', 'int'), isField: true, isFinal: true);
+    generator.addDeclaration(new TypeIdentifier('a.dart', 'A'), 'bar',
+        new TypeIdentifier('dart:core', 'Function'), isMethod: true,
+        annotations: [new ConstExpression.constructor(null, 'Annotation',
+          [new ConstExpression.string("hi")], const {})]);
+    _checkResults(generator,
+        imports: ["import 'a.dart' as smoke_0;"],
+        initCall:
+            'useGeneratedCode(new StaticConfiguration(\n'
+            '    checkedMode: false,\n'
+            '    declarations: {\n'
+            '      smoke_0.A: {\n'
+            '        #bar: const Declaration(#bar, Function, kind: METHOD, '
+                           'annotations: const [const Annotation(\'hi\')]),\n'
+            '        #foo: const Declaration(#foo, int, isFinal: true),\n'
+            '      },\n'
+            '    }));\n');
+  });
+
+  test('repeated entries appear only once', () {
+    var generator = new SmokeCodeGenerator();
+    generator.addGetter('a');
+    generator.addGetter('a');

[Jennifer Messerly, 2014/03/17 22:38:48]

hmmm. I wonder if this should be an error?

[Siggi Cherem (dart-lang), 2014/03/18 01:52:29]

good question. I had it as an error initially, but then I realized it was better
to allow it. The way this is used with the recorder is that we'll be executing
static queries and request data from those queries to be appended to the
generator. Some queries might have common symbols and getters, even when they
are referring to different members. For example, I could request to append
getters for all fields in class A, and all fields in class B:

  class A { int x; }
  class B { int x; }

After running into these issues, I changed this code to allow it. That's why I
added this test so make sure that even if you add it more than once, the output
only reflects it once.

[Jennifer Messerly, 2014/03/19 00:15:48]

makes sense :)

+    generator.addSetter('b');
+    generator.addSetter('b');
+    generator.addSymbol('d');
+    generator.addSymbol('d');
+    generator.addSymbol('c');
+    generator.addSymbol('c');
+    generator.addSymbol('c');
+
+    generator.addParent(new TypeIdentifier('a.dart', 'C'),
+        new TypeIdentifier('a.dart', 'A'));
+    generator.addParent(new TypeIdentifier('a.dart', 'C'),
+        new TypeIdentifier('a.dart', 'A'));
+    generator.addParent(new TypeIdentifier('a.dart', 'C'),
+        new TypeIdentifier('a.dart', 'A'));
+
+    generator.addDeclaration(new TypeIdentifier('a.dart', 'A'), 'foo',
+        new TypeIdentifier('dart:core', 'int'), isField: true, isFinal: true);
+    generator.addDeclaration(new TypeIdentifier('a.dart', 'A'), 'foo',
+        new TypeIdentifier('dart:core', 'int'), isField: true, isFinal: true);
+    generator.addDeclaration(new TypeIdentifier('a.dart', 'A'), 'foo',
+        new TypeIdentifier('dart:core', 'int'), isField: true, isFinal: true);
+
+    _checkResults(generator,
+        imports: [
+          "import 'a.dart' as smoke_0;",
+        ],
+        initCall:
+          'useGeneratedCode(new StaticConfiguration(\n'
+          '    checkedMode: false,\n'
+          '    getters: {\n'
+          '      #a: (o) => o.a,\n'
+          '    },\n'
+          '    setters: {\n'
+          '      #b: (o, v) { o.b = v; },\n'
+          '    },\n'
+          '    parents: {\n'
+          '      smoke_0.C: smoke_0.A,\n'
+          '    },\n'
+          '    declarations: {\n'
+          '      smoke_0.A: {\n'
+          '        #foo: const Declaration(#foo, int, isFinal: true),\n'
+          '      },\n'
+          '    },\n'
+          '    names: {\n'
+          '      #c: \'c\',\n'
+          '      #d: \'d\',\n'
+          '    }));\n');
+  });
+}
+
+_checkResults(SmokeCodeGenerator generator, {List<String> imports: const [],
+    String topLevel: '', String initCall}) {
+  var allImports = []..addAll(DEFAULT_IMPORTS)..addAll(imports);
+  expect(generator.generateImports(), allImports);
+  expect(generator.generateTopLevelDeclarations(), topLevel);
+  var indentedCode = initCall.replaceAll("\n", "\n  ").trim();
+  expect(generator.generateInitCall(), '  $indentedCode\n');
+}